In our setup every app has trigger.onCommit.disabled: true.
The side effect is that pipectl plan-preview (and the actions-plan-preview GitHub Action) always returns "no updated applications" for us. We lose the PR diff preview entirely, even though that's
exactly what we'd want during code review.
The gate is here:
// pkg/app/piped/trigger/determiner.go
func (d *OnCommitDeterminer) ShouldTrigger(...) (bool, error) {
if appCfg.Trigger.OnCommit.Disabled {
return false, nil
}
...
}builder.findTriggerApps uses the same determiner, so apps with onCommit.disabled: true are filtered out before any diff is computed.
Would it be possible to add a flag like --skip-trigger-check to pipectl plan-preview (and a corresponding input on actions-plan-preview) that bypasses this gate? plan-preview is a read-only operation, so
opting in per-invocation feels safer than changing the app config. Default would stay as today.
Happy to send a PR if the direction sounds good.
In our setup every app has
trigger.onCommit.disabled: true.The side effect is that
pipectl plan-preview(and theactions-plan-previewGitHub Action) always returns "no updated applications" for us. We lose the PR diff preview entirely, even though that'sexactly what we'd want during code review.
The gate is here:
builder.findTriggerApps uses the same determiner, so apps with onCommit.disabled: true are filtered out before any diff is computed.
Would it be possible to add a flag like --skip-trigger-check to pipectl plan-preview (and a corresponding input on actions-plan-preview) that bypasses this gate? plan-preview is a read-only operation, so
opting in per-invocation feels safer than changing the app config. Default would stay as today.
Happy to send a PR if the direction sounds good.