pd: fix wrong description about inspect-network-interval (#22416)

[ti-chi-bot]

This is an automated cherry-pick of #22416

First-time contributors' checklist

• I've signed the Contributor License Agreement, which is required for the repository owners to accept my contribution.

What is changed, added or deleted? (Required)

Which TiDB version(s) do your changes apply to? (Required)

Tips for choosing the affected version(s):

By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.

For details, see tips for choosing the affected versions.

• master (the latest development version)
• v9.0 (TiDB 9.0 versions)
• v8.5 (TiDB 8.5 versions)
• v8.1 (TiDB 8.1 versions)
• v7.5 (TiDB 7.5 versions)
• v7.1 (TiDB 7.1 versions)
• v6.5 (TiDB 6.5 versions)
• v6.1 (TiDB 6.1 versions)
• v5.4 (TiDB 5.4 versions)

What is the related PR or file link(s)?

• This PR is translated from:pd: fix wrong description about inspect-network-interval docs-cn#21330
• Other reference link(s):

Do your changes match any of the following descriptions?

• Delete files
• Change aliases
• Need modification after applied to another branch
• Might cause conflicts after applied to another branch

[ti-chi-bot]

@hfxsd This PR has conflicts, I have hold it.
Please resolve them or ask others to resolve them, then comment /unhold to remove the hold label.

[ti-chi-bot]

@ti-chi-bot: ## If you want to know how to resolve it, please read the guide in TiDB Dev Guide.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

[gemini-code-assist]

Summary of Changes

Hello @ti-chi-bot, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses inaccuracies in the documentation concerning the default behavior and configuration of slow-network node detection and scheduling within TiKV and PD. The changes provide clearer and more precise guidance on how these features operate and how to configure them, ensuring users have correct information for managing network-related performance issues.

Highlights

• Clarified TiKV Slow-Network Node Detection Default Behavior: The documentation now accurately states that TiKV's slow-network node detection is enabled by default, with raftstore.inspect-network-interval controlling the probing frequency rather than enabling the feature.
• Corrected PD Slow-Network Node Scheduling Configuration: The instructions for enabling slow-network node scheduling on the PD side have been clarified, explicitly noting that it is disabled by default and requires specific configuration to activate.
• Updated Version Applicability: The documentation for slow-network node detection now correctly includes both v8.5.5 and v9.0.0 as applicable versions.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• best-practices/pd-scheduling-best-practices.md
  • Updated the version reference for slow-network node detection to include v9.0.0.
  • Added a note clarifying that enable-network-slow-store is disabled by default.
• pd-control.md
  • Revised the description of TiKV's slow-network node detection, stating it is enabled by default with a 100ms probing interval.
  • Clarified that the raftstore.inspect-network-interval configuration item is used to adjust the probing frequency, not to enable the feature.
  • Differentiated between TiKV's detection (enabled by default) and PD's scheduling (disabled by default), providing correct instructions for enabling the latter.

Activity

• This pull request is an automated cherry-pick of an earlier change, pd: fix wrong description about inspect-network-interval #22416.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request aims to fix an incorrect description for inspect-network-interval. The changes clarify that network-slow-node detection is enabled by default in TiKV, and scheduling for it is disabled by default in PD.

My review has identified critical issues related to unresolved merge conflicts in both modified files. These must be resolved. Additionally, I've found a potentially broken link in pd-control.md due to an incorrect anchor.

My feedback is based on the repository's documentation style guide, focusing on technical accuracy (correct links) and clarity/readability (resolving merge conflicts). I've provided suggestions to fix these issues. Please resolve the merge conflicts and verify the link anchor.

[hfxsd]

/approve

[ti-chi-bot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: hfxsd

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [hfxsd]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment