cloud: update tidb_dml_type limitation#22415
cloud: update tidb_dml_type limitation#22415ti-chi-bot[bot] merged 2 commits intopingcap:release-8.5from
Conversation
ti-chi-bot
bot
added
contribution
|
Hi @zuowei593. Thanks for your PR. I'm waiting for a pingcap member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Summary of ChangesHello @zuowei593, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the TiDB Cloud documentation by explicitly listing the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
ti-chi-bot
bot
added
missing-translation-status
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request adds the tidb_dml_type system variable to the list of limited SQL features on TiDB Cloud, marking it as read-only for Starter and Essential clusters. The change is correctly placed and formatted.
Following the repository's documentation style guide, I've added a comment suggesting an update to another file to ensure documentation completeness and avoid user confusion.
Additionally, please note that the required TiDB version information is missing from the pull request description. Please fill that in.
| | `tidb_ddl_reorg_batch_size` | No limitation | Read-only [^10] | | ||
| | `tidb_ddl_reorg_priority` | No limitation | Read-only [^10] | | ||
| | `tidb_ddl_reorg_worker_cnt` | No limitation | Read-only [^10] | | ||
| | `tidb_dml_type` | No limitation | Read-only [^10] | |
There was a problem hiding this comment.
This correctly adds the limitation for tidb_dml_type. To ensure documentation completeness and consistency, please also add a note in system-variables.md indicating that this variable is read-only for TiDB Cloud Starter and Essential clusters. This helps users who might only read that document and avoids potential confusion.
References
- The style guide emphasizes completeness in documentation (line 14). A corresponding note in
system-variables.mdis needed to make the documentation about this limitation complete. (link) - The style guide suggests making changes if something might confuse a new user (line 63). The lack of a note in
system-variables.mdcould be confusing. (link)
|
@AmoebaProtozoa: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@iosmanthus: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
@ystaticy: adding LGTM is restricted to approvers and reviewers in OWNERS files. DetailsIn response to this: Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
LGTM |
…ad-only for TiDB Cloud Starter and Essential clusters
qiancai
added
the
needs-cherry-pick-master
|
/ok-to-test |
ti-chi-bot
bot
added
ok-to-test
[LGTM Timeline notifier]Timeline:
|
qiancai
added
area/tidb-cloud
ti-chi-bot
bot
removed
the
missing-translation-status
qiancai
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiancai The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
In response to a cherrypick label: new pull request created to branch |
7 participants
First-time contributors' checklist
What is changed, added or deleted? (Required)
Which TiDB version(s) do your changes apply to? (Required)
Tips for choosing the affected version(s):
By default, CHOOSE MASTER ONLY so your changes will be applied to the next TiDB major or minor releases. If your PR involves a product feature behavior change or a compatibility change, CHOOSE THE AFFECTED RELEASE BRANCH(ES) AND MASTER.
For details, see tips for choosing the affected versions.
What is the related PR or file link(s)?
Do your changes match any of the following descriptions?