The tests/unit/parsers.cpp test fails: test 'p.options.size() == std::size_t(1)' faile

[yurivict]

$ ./parsers_test 
/usr/ports/devel/pika/work/pika-0.33.0/libs/pika/program_options/tests/unit/parsers.cpp(265): test 'p.options.size() == std::size_t(1)' failed in function 'void test_environment()': '0 != 1'
Illegal instruction

Version: 0.33.0
clang-19.1.7
FreeBSD 14.2

[msimberg]

Thanks for reporting. Do you have more information about the failure? A core dump/backtrace? I'm guessing the illegal instruction is a consequence of test failure reporting gone bad. Obviously the test should not fail in the first place.

[yurivict]

I also think that the illegal instruction is secondary.

Here is the stack trace:

Program received signal SIGILL, Illegal instruction.
Privileged opcode.
std::__1::vector<pika::program_options::basic_option<char>, std::__1::allocator<pika::program_options::basic_option<char> > >::operator[][abi:se190107](unsigned long)
    (this=0x7fffffffe2c0, __n=0) at /usr/include/c++/v1/vector:1436
1436      _LIBCPP_ASSERT_VALID_ELEMENT_ACCESS(__n < size(), "vector[] index out of bounds");
(gdb) bt
#0  std::__1::vector<pika::program_options::basic_option<char>, std::__1::allocator<pika::program_options::basic_option<char> > >::operator[][abi:se190107](unsigned lo
ng) (this=0x7fffffffe2c0, __n=0) at /usr/include/c++/v1/vector:1436
#1  0x000000000021b7a9 in test_environment () at /usr/ports/devel/pika/work/pika-0.33.0/libs/pika/program_options/tests/unit/parsers.cpp:266
#2  0x000000000021c2e8 in main () at /usr/ports/devel/pika/work/pika-0.33.0/libs/pika/program_options/tests/unit/parsers.cpp:337
(gdb)

Failure location:

258│ #if defined(_WIN32) || defined(__CYGWIN__)
259│     _putenv("PO_TEST_FOO=1");
260│ #else
261│     putenv(const_cast<char*>("PO_TEST_FOO=1"));
262│ #endif
263│     parsed_options p = parse_environment(desc, "PO_TEST_");
264│
265│     PIKA_TEST_EQ(p.options.size(), std::size_t(1));
266├───> PIKA_TEST_EQ(p.options[0].string_key, "foo");
267│     PIKA_TEST_EQ(p.options[0].value.size(), std::size_t(1));
268│     PIKA_TEST_EQ(p.options[0].value[0], "1");
269│
270│     //TODO: since 'bar' does not allow a value, it cannot appear in environment,
271│     // which already has a value.