Fix admonition class handling

Author: jaapio

packages/guides-restructured-text/src/RestructuredText/Compiler/Passes/DirectiveProcessPass.php

@@ -23,10 +23,9 @@
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 use Psr\Log\LoggerInterface;
 
+use function array_merge;
 use function strtolower;
 
-use const PHP_INT_MAX;
-
 /** @implements NodeTransformer<DirectiveNode> */
 final class DirectiveProcessPass implements ReverseNodeTransformer
 {
@@ -64,7 +63,7 @@ public function leaveNode(Node $node, CompilerContext $compilerContext): Node|nu
             return null;
         }
 
-        $newNode->setClasses($node->getClasses());
+        $newNode->setClasses(array_merge($newNode->getClasses(), $node->getClasses()));
 
         return $newNode;
     }

packages/guides-restructured-text/src/RestructuredText/Directives/AbstractAdmonitionDirective.php

@@ -13,7 +13,6 @@
 
 namespace phpDocumentor\Guides\RestructuredText\Directives;
 
-use Doctrine\Deprecations\Deprecation;
 use phpDocumentor\Guides\Nodes\AdmonitionNode;
 use phpDocumentor\Guides\Nodes\CollectionNode;
 use phpDocumentor\Guides\Nodes\Node;
@@ -56,11 +55,15 @@ public function createNode(DirectiveNode $directiveNode): Node|null
             array_unshift($children, new ParagraphNode([$directiveNode->getDirective()->getDataNode()]));
         }
 
-        return new AdmonitionNode(
+        $node = new AdmonitionNode(
             $directiveNode->getDirective()->getName(),
             null,
             $this->text,
             $children,
         );
+
+        $node->setClasses([$directiveNode->getDirective()->getOptionString('class')]);
+
+        return $node;
     }
 }

packages/guides-restructured-text/src/RestructuredText/Directives/AbstractVersionChangeDirective.php

@@ -14,6 +14,7 @@
 namespace phpDocumentor\Guides\RestructuredText\Directives;
 
 use Doctrine\Deprecations\Deprecation;
+use LogicException;
 use phpDocumentor\Guides\Nodes\CollectionNode;
 use phpDocumentor\Guides\Nodes\Node;
 use phpDocumentor\Guides\RestructuredText\Nodes\DirectiveNode;
@@ -22,6 +23,8 @@
 use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 use phpDocumentor\Guides\RestructuredText\Parser\Productions\Rule;
 
+use function sprintf;
+
 /** @see https://www.sphinx-doc.org/en/master/usage/restructuredtext/directives.html#directive-versionadded */
 abstract class AbstractVersionChangeDirective extends SubDirective
 {
@@ -51,7 +54,7 @@ public function getName(): string
     {
         try {
             return parent::getName();
-        } catch (\LogicException) {
+        } catch (LogicException) {
             Deprecation::trigger(
                 'phpdocumentor/guides-restructured-text',
                 'TODO: link',

packages/guides-restructured-text/src/RestructuredText/Directives/BreadcrumbDirective.php

@@ -16,8 +16,6 @@
 use phpDocumentor\Guides\Nodes\BreadCrumbNode;
 use phpDocumentor\Guides\Nodes\Node;
 use phpDocumentor\Guides\RestructuredText\Nodes\DirectiveNode;
-use phpDocumentor\Guides\RestructuredText\Parser\BlockContext;
-use phpDocumentor\Guides\RestructuredText\Parser\Directive;
 
 /**
  * The "breadcrumb" directive displays a breadcrumb of the current. It does not exist in Sphinx or the

packages/guides-restructured-text/src/RestructuredText/Parser/Directive.php

@@ -15,6 +15,8 @@
 
 use phpDocumentor\Guides\Nodes\InlineCompoundNode;
 
+use function strtolower;
+
 /**
  * Represents the data contained in an arbitrary directive
  *

packages/guides/src/Compiler/ReverseNodeTransformer.php

@@ -2,6 +2,15 @@
 
 declare(strict_types=1);
 
+/**
+ * This file is part of phpDocumentor.
+ *
+ * For the full copyright and license information, please view the LICENSE
+ * file that was distributed with this source code.
+ *
+ * @link https://phpdoc.org
+ */
+
 namespace phpDocumentor\Guides\Compiler;
 
 /**
@@ -11,5 +20,4 @@
  */
 interface ReverseNodeTransformer extends NodeTransformer
 {
-
 }

packages/guides/src/Nodes/AbstractNode.php

@@ -77,7 +77,7 @@ public function setClasses(array $classes): void
             // strip trailing hyphens
             $value = (string) preg_replace('/-$/', '', $value);
         });
-        $this->classes = array_unique($classes);
+        $this->classes = array_filter(array_unique($classes), static function (string $value): bool { return $value !== ''; });
     }
 
     public function getClassesString(): string