Merge pull request #113 from tyrsson/fix-connectioninterface

Fixes the param/return type for getLastGeneratedValue in ConnectionInterface

Author: tyrsson

src/Adapter/Driver/ConnectionInterface.php

@@ -23,12 +23,9 @@ public function getConnectionParameters(): array;
     /**
      * Get last generated id
      *
-     * @param null $name Ignored (this is not ignored for PDO), imagine that...
-     *
-     * todo: narrow this to string|int|bool|null
-     * until version bumps to PHP 8.2 minimum then narrow to string|int|false
+     * $name Ignored (this is not ignored for PDO), imagine that...
      */
-    public function getLastGeneratedValue($name = null): string|int|bool|null;
+    public function getLastGeneratedValue(?string $name = null): string|int|false|null;
 
     /**
      * Get resource

test/unit/Adapter/Driver/Pdo/TestAsset/TestConnection.php

@@ -52,11 +52,9 @@ private function buildDsn(): string
         };
     }
 
-    /**
-     * @param string|null $name
-     */
+    /** @phpstan-ignore return.unusedType */
     #[Override]
-    public function getLastGeneratedValue($name = null): string|bool|null
+    public function getLastGeneratedValue(?string $name = null): string|int|false
     {
         return $this->resource?->lastInsertId($name) ?? null;
     }

test/unit/TestAsset/ConnectionWrapper.php

@@ -29,9 +29,9 @@ public function getCurrentSchema(): string
         return 'test_schema';
     }
 
-    public function getLastGeneratedValue(mixed $name = null): int|string|bool|null
+    public function getLastGeneratedValue(?string $name = null): string|int|false
     {
-        return null;
+        return false;
     }
 
     public function getNestedTransactionsCount(): int