Skip to content

Commit c68d790

Browse files
authored
Fix one-character typo in XFoil.alpha() causing TypeError with list input (#177)
Possibly the smallest PR you'll ever review. `alphas[alpha <= start_at]` on line _**655**_ should be `alphas[alphas <= start_at]`. The preceding line gets it right; this one missed the rename from `alpha` to `alphas`. This causes a `TypeError` when `alpha` is passed as a Python list (the default `start_at=0` triggers the code path), contradicting the docstring which explicitly allows "a float or an iterable of floats, such as an array".
2 parents 0e24389 + c491731 commit c68d790

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

  • aerosandbox/aerodynamics/aero_2D

aerosandbox/aerodynamics/aero_2D/xfoil.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -652,7 +652,7 @@ def schedule_run(alpha: float):
652652
and (np.min(alphas) < start_at < np.max(alphas))
653653
):
654654
alphas_upper = alphas[alphas > start_at]
655-
alphas_lower = alphas[alpha <= start_at][::-1]
655+
alphas_lower = alphas[alphas <= start_at][::-1]
656656

657657
for a in alphas_upper:
658658
schedule_run(a)

0 commit comments

Comments
 (0)