Skip to content

Commit 41f0120

Browse files
authored
Merge pull request #2934 from finos/tsc-cleanup
Shrink `d3fc` bundle
2 parents c40ade0 + ce7bc47 commit 41f0120

40 files changed

+48
-38
lines changed

cpp/perspective/CMakeLists.txt

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -232,6 +232,7 @@ if(PSP_WASM_BUILD)
232232
-g3 \
233233
-Wcast-align \
234234
-Wover-aligned \
235+
-emit-tsd=perspective-server.d.ts \
235236
")
236237
if (PSP_WASM_EXCEPTIONS)
237238
set(OPT_FLAGS "${OPT_FLAGS} -fwasm-exceptions ")

packages/perspective-cli/package.json

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -33,5 +33,8 @@
3333
"@finos/perspective-workspace": "workspace:^",
3434
"commander": "^2.19.0",
3535
"puppeteer": "^23"
36+
},
37+
"devDependencies": {
38+
"@finos/perspective-test": "workspace:^"
3639
}
3740
}

packages/perspective-viewer-d3fc/build.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -66,7 +66,6 @@ const BUILD = [
6666
},
6767
plugins: [],
6868
format: "esm",
69-
metafile: false,
7069
loader: {
7170
".css": "text",
7271
".html": "text",

packages/perspective-viewer-d3fc/src/ts/axis/axisFactory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

13-
import * as fc from "d3fc";
13+
import * as fc from "d3fc/index.js";
1414
import { AxisTypeValues, axisType } from "./axisType";
1515
import * as none from "./noAxis";
1616
import * as linear from "./linearAxis";

packages/perspective-viewer-d3fc/src/ts/axis/axisLabel.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

13-
import { rebindAll } from "d3fc";
13+
import { rebindAll } from "d3fc/index.js";
1414
import { axisType } from "./axisType";
1515
import { labelFunction as noLabel } from "./noAxis";
1616
import { labelFunction as timeLabel } from "./timeAxis";

packages/perspective-viewer-d3fc/src/ts/axis/chartFactory.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

1313
import * as d3 from "d3";
14-
import * as fc from "d3fc";
14+
import * as fc from "d3fc/index.js";
1515

1616
export const chartSvgFactory = (xAxis, yAxis) =>
1717
chartFactory(xAxis, yAxis, (x, y) => x.svgPlotArea(y), false);

packages/perspective-viewer-d3fc/src/ts/axis/linearAxis.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

1313
import * as d3 from "d3";
14-
import * as fc from "d3fc";
14+
import * as fc from "d3fc/index.js";
1515
import { flattenArray } from "./flatten";
1616
import { extentLinear as customExtent } from "../d3fc/extent/extentLinear";
1717
import { getValueFormatterForRange } from "./valueFormatter";

packages/perspective-viewer-d3fc/src/ts/axis/minBandwidth.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

13-
import { rebindAll } from "d3fc";
13+
import { rebindAll } from "d3fc/index.js";
1414

1515
const MIN_BANDWIDTH = 1;
1616

packages/perspective-viewer-d3fc/src/ts/axis/ordinalAxis.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

1313
import * as d3 from "d3";
14-
import * as fc from "d3fc";
14+
import * as fc from "d3fc/index.js";
1515
import minBandwidth from "./minBandwidth";
1616
import { flattenArray } from "./flatten";
1717
import {

packages/perspective-viewer-d3fc/src/ts/axis/splitterLabels.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
// ┃ of the [Apache License 2.0](https://www.apache.org/licenses/LICENSE-2.0). ┃
1111
// ┗━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━┛
1212

13-
import * as fc from "d3fc";
13+
import * as fc from "d3fc/index.js";
1414
import { getChartElement } from "../plugin/root";
1515
import { withoutOpacity } from "../series/seriesColors.js";
1616
import { HTMLSelection, Settings } from "../types";

0 commit comments

Comments
 (0)