[BUGFIX] Add lint command in ClickHouse and fix linter errors (#547)

* linter fix

Signed-off-by: rafi <rafialam@appscode.com>

* fix type error in test file

Signed-off-by: rafi <rafialam@appscode.com>

---------

Signed-off-by: rafi <rafialam@appscode.com>

Author: rafi-ruetcse17

clickhouse/package.json

@@ -8,6 +8,7 @@
     "build:cjs": "swc ./src -d dist/lib/cjs --strip-leading-paths --config-file ../.cjs.swcrc",
     "build:esm": "swc ./src -d dist/lib --strip-leading-paths --config-file ../.swcrc",
     "build:types": "tsc --project tsconfig.build.json",
+    "lint": "eslint src --ext .ts,.tsx",
     "test": "cross-env LC_ALL=C TZ=UTC jest",
     "type-check": "tsc --noEmit"
   },

clickhouse/src/datasources/click-house-datasource/ClickHouseDatasource.tsx

@@ -12,9 +12,9 @@
 // limitations under the License.
 
 import { DatasourcePlugin } from '@perses-dev/plugin-system';
+import { query } from '../../model/click-house-client';
 import { ClickHouseDatasourceSpec, ClickHouseDatasourceClient } from './click-house-datasource-types';
 import { ClickHouseDatasourceEditor } from './ClickHouseDatasourceEditor';
-import { query } from '../../model/click-house-client';
 
 const createClient: DatasourcePlugin<ClickHouseDatasourceSpec, ClickHouseDatasourceClient>['createClient'] = (
   spec,

clickhouse/src/datasources/click-house-datasource/click-house-datasource-types.ts

@@ -34,7 +34,7 @@ export interface ClickHouseDatasourceResponse {
   status: string;
   warnings?: string[];
   // TODO: adjust this type to match your datasource response shape
-  data: any;
+  data: unknown;
 }
 
 export interface ClickHouseDatasourceClient extends DatasourceClient {

clickhouse/src/model/click-house-client.ts

@@ -25,7 +25,7 @@ export interface ClickHouseQueryOptions {
 
 export interface ClickHouseQueryResponse {
   status: 'success' | 'error';
-  data: any;
+  data: unknown;
 }
 
 export interface ClickHouseClient {

clickhouse/src/model/click-house-data-types.ts

@@ -11,7 +11,7 @@
 // See the License for the specific language governing permissions and
 // limitations under the License.
 
-import { LogEntry, LogData, TimeSeriesData } from '@perses-dev/core';
+import { LogData, TimeSeriesData } from '@perses-dev/core';
 
 export interface ClickHouseTimeSeriesData extends TimeSeriesData {
   logs?: LogData;

clickhouse/src/queries/click-house-log-query/get-click-house-log-data.ts

@@ -14,19 +14,19 @@
 import { replaceVariables } from '@perses-dev/plugin-system';
 import { LogEntry, LogData } from '@perses-dev/core';
 import { ClickHouseClient, ClickHouseQueryResponse } from '../../model/click-house-client';
-import { ClickHouseLogQuerySpec } from './click-house-log-query-types';
 import { DEFAULT_DATASOURCE } from '../constants';
+import { ClickHouseLogQuerySpec } from './click-house-log-query-types';
 import { LogQueryPlugin } from './log-query-plugin-interface';
 
 function flattenObject(
-  obj: Record<string, any>,
+  obj: Record<string, unknown>,
   parentKey = '',
-  result: Record<string, any> = {}
-): Record<string, any> {
+  result: Record<string, unknown> = {}
+): Record<string, unknown> {
   for (const [key, value] of Object.entries(obj)) {
     const newKey = parentKey ? `${parentKey}.${key}` : key;
     if (value && typeof value === 'object' && !Array.isArray(value)) {
-      flattenObject(value, newKey, result);
+      flattenObject(value as Record<string, unknown>, newKey, result);
     } else {
       result[newKey] = value;
     }
@@ -37,13 +37,13 @@ function flattenObject(
 
 function convertStreamsToLogs(streams: LogEntry[]): LogData {
   const entries: LogEntry[] = streams.map((entry) => {
-    const flattened = flattenObject(entry);
+    const flattened = flattenObject(entry as unknown as Record<string, unknown>);
 
-    if (!flattened.Timestamp && flattened.log_time) {
-      flattened.Timestamp = flattened.log_time;
+    if (!flattened['Timestamp'] && flattened['log_time']) {
+      flattened['Timestamp'] = flattened['log_time'];
     }
 
-    const sortedEntry: Record<string, any> = {};
+    const sortedEntry: Record<string, unknown> = {};
     Object.keys(flattened)
       .sort((a, b) => a.localeCompare(b))
       .forEach((key) => {
@@ -56,8 +56,8 @@ function convertStreamsToLogs(streams: LogEntry[]): LogData {
       .join(' ');
 
     return {
-      timestamp: sortedEntry?.Timestamp,
-      labels: sortedEntry,
+      timestamp: sortedEntry?.['Timestamp'] as unknown as number,
+      labels: sortedEntry as Record<string, string>,
       line,
     } as LogEntry;
   });
@@ -92,7 +92,7 @@ export const getClickHouseLogData: LogQueryPlugin<ClickHouseLogQuerySpec>['getLo
 
   return {
     timeRange: { start, end },
-    logs: convertStreamsToLogs(response.data),
+    logs: convertStreamsToLogs(response.data as LogEntry[]),
     metadata: {
       executedQueryString: query,
     },

clickhouse/src/queries/click-house-time-series-query/click-house-query-types.test.ts

@@ -54,7 +54,7 @@ const getDatasource: jest.Mock = jest.fn((): DatasourceSpec<ClickHouseDatasource
 });
 
 const createStubContext = (): TimeSeriesQueryContext => {
-  const stubTimeSeriesContext: TimeSeriesQueryContext = {
+  const stubTimeSeriesContext: Partial<TimeSeriesQueryContext> = {
     datasourceStore: {
       getDatasource: getDatasource,
       getDatasourceClient: getDatasourceClient,
@@ -70,7 +70,7 @@ const createStubContext = (): TimeSeriesQueryContext => {
     },
     variableState: {},
   };
-  return stubTimeSeriesContext;
+  return stubTimeSeriesContext as TimeSeriesQueryContext;
 };
 
 describe('ClickHouseTimeSeriesQuery', () => {

clickhouse/src/queries/click-house-time-series-query/click-house-query-types.ts

@@ -21,6 +21,6 @@ export interface ClickHouseTimeSeriesQuerySpec {
 // TODO: import this type from your datasource or an existing datasource plugin
 export type DatasourceQueryResponse = {
   status: string;
-  data: any;
+  data: unknown;
   warnings?: string[];
 };

clickhouse/src/queries/click-house-time-series-query/get-click-house-data.ts

@@ -13,17 +13,18 @@
 
 import { TimeSeries } from '@perses-dev/core';
 import { TimeSeriesQueryPlugin, replaceVariables } from '@perses-dev/plugin-system';
-import { ClickHouseTimeSeriesQuerySpec, DatasourceQueryResponse } from './click-house-query-types';
 import { DEFAULT_DATASOURCE } from '../constants';
 import { TimeSeriesEntry } from '../../model/click-house-data-types';
 import { ClickHouseClient, ClickHouseQueryResponse } from '../../model/click-house-client';
+import { ClickHouseTimeSeriesQuerySpec, DatasourceQueryResponse } from './click-house-query-types';
 
 function buildTimeSeries(response?: DatasourceQueryResponse): TimeSeries[] {
-  if (!response || !response.data || response.data.length === 0) {
+  const data = response?.data as TimeSeriesEntry[];
+  if (!response || !data || data.length === 0) {
     return [];
   }
 
-  const values: Array<[number, number]> = response.data.map((row: TimeSeriesEntry) => {
+  const values: Array<[number, number]> = data.map((row: TimeSeriesEntry) => {
     const timestamp = new Date(row.time).getTime();
     const value = Number(row.log_count);
     return [timestamp, value];

clickhouse/src/queries/query-editor-model.ts

@@ -28,7 +28,9 @@ type ClickHouseQuerySpec = {
  * changes with the overall spec value once the input is blurred to prevent re-running queries in the panel's preview
  * every time the user types.
  */
-export function useQueryState<T extends ClickHouseQuerySpec>(props: OptionsEditorProps<T>): {
+export function useQueryState<T extends ClickHouseQuerySpec>(
+  props: OptionsEditorProps<T>
+): {
   query: string;
   handleQueryChange: (e: string) => void;
   handleQueryBlur: () => void;