Node FQDN validation incorrectly prevents IP addresses when Panel is served over HTTPS

[NeilHanlon]

Current Behavior

When the panel is served over HTTPS, entering an IP address as a node's FQDN displays a red error: "You cannot connect to an IP address over SSL." and blocks saving. The validation in CreateNode.php and EditNode.php checks request()->isSecure(), which appears to test whether the connection to the Panel is over HTTPS, and refuses to allow an IP address in the node address field.

TLS works just fine on IP addresses with self-signed certs, internal CAs, and even DNS-01 ACME challenges.

Expected Behavior

There should be no error when entering an IP address as a node FQDN an connecting to it with TLS. A soft, non-error hint like "Considering using a domain anem for easier TLS certificate management" would be reasonable, but it shouldn't be presented as an error or imply it is impossible.

Steps to Reproduce

1. Access the panel over HTTPS
2. Go to Admin -> Nodes -> Create New
3. Enter an IP address (e.g. 1.2.3.4) as the FQDN
4. Observe the red error: "You cannot connect to an IP Address over SSL"

Panel Version

1.0.0-beta33

Wings Version

N/A

Games and/or Eggs Affected

N/A

Docker Image

No response

Error Logs

Is there an existing issue for this?

• I have searched the existing issues before opening this issue.
• I have provided all relevant details, including the specific game and Docker images I am using if this issue is related to running a server.
• I have checked in the Discord server and believe this is a bug with the software, and not a configuration issue with my specific system.

[JoanFo1456]

This was made before external IPs could have certificates (like normal people could do it) I guess they need to check on changing that.

[NeilHanlon]

This was made before external IPs could have certificates (like normal people could do it) I guess they need to check on changing that.

Yeah, I figured that was probably the case so I thought I'd open an issue to discuss rather than try and implement a fix myself without any context. Low priority for me anyways, but would be nice.