feat(es): Patches for bugs introduced in 2.4 and 2.5 releases (#187)

* Patches for bugs introduced in 2.4 and 2.5 releases

* Use blacklist; revert change to libpostal source file

Author: ianthetechie

classifier/scheme/venue.js

@@ -186,7 +186,7 @@ module.exports = [
     scheme: [
       {
         is: ['PlaceClassification', 'VenueClassification'],
-        not: ['StreetClassification']
+        not: ['StreetClassification', 'StreetSuffixClassification']
       },
       {
         is: ['AlphaClassification'],

resources/pelias/dictionaries/libpostal/nb/concatenated_suffixes_separable.txt

@@ -0,0 +1,2 @@
+# Causes a bunch of issues with Spanish addresses ("Calle" is a common prefix)
+!alle

test/address.esp.test.js

@@ -5,6 +5,11 @@ const testcase = (test, common) => {
     { street: 'Carrer d\'Aragó' }, { housenumber: '155' },
     { postcode: '08011' }, { locality: 'Barcelona' }
   ])
+
+  assert('Calle Principal 20 Barcelona', [
+    { street: 'Calle Principal' }, { housenumber: '20' },
+    { locality: 'Barcelona' }
+  ])
 }
 
 module.exports.all = (tape, common) => {

test/address.usa.test.js

@@ -285,6 +285,11 @@ const testcase = (test, common) => {
   // https://github.com/pelias/pelias/issues/912
   assert('Jefferson Parish', [{ locality: 'Jefferson' }])
   assert('Mills County', [{ locality: 'Mills' }])
+
+  // Partial admin match that triggered a regression in 2.5.0
+  assert('Main St Seattl', [
+    { street: 'Main St' }
+  ])
 }
 
 module.exports.all = (tape, common) => {