Quotes within a PHP tag aren't ignored

[benjibee]

Quotes within a PHP tag aren't ignored as they should be. This causes syntax highlighting to break.

Here's an example of an inline PHP tag within a <script> tag with proper JavaScript syntax highlighting:

Here's the same example using this plugin:

The syntax highlighting is broken after encountering the first ' inside of the PHP statement as it thinks it's a matching quote. If I swap single or double quote on the attribute it has the same issue.

[benjibee]

Came here to report this issue and realized I had already reported it. So, um, I'm bumping my own issue I guess 🤷

[pcbowers]

@benjibee I don't use PHP a whole lot, and wrote this primarily for myself in development with some of the HTML projects that I use. I have utilized customData mainly to support this, along with a little injection syntax for highlighting.

That said, injections aren't fail proof and they do result in errors like you see here. I'm researching to see if there's maybe a better solution that doesn't require an injection syntax while still staying lean (I don't have the time currently to write a language server just for this). I haven't found anything yet. If you want to take a stab at editing the injection syntax, I'm open to pull requests! I just don't use PHP, so wouldn't be the best person to support this.

[benjibee]

@pcbowers thanks for the info. I've got this on a list of PRs I'd very much like to work on once I have the free time. If I can contribute in any way, I'd be happy to.