#3467 lsp: add context menu

Signed-off-by: Patrizio Bekerle <patrizio@bekerle.com>

Author: pbek

CHANGELOG.md

@@ -2,6 +2,20 @@
 
 ## 26.4.23
 
+- Fixed a URI percent-encoding mismatch that prevented Markdown LSP diagnostics
+  from being applied when a note filename contains spaces; the incoming LSP URI
+  (e.g. `Top%20heading.md`) is now decoded with `QUrl::fromPercentEncoding`
+  before being compared to the stored document URI so wave-underlines appear
+  correctly for notes with spaces in their name
+  (for [#3467](https://github.com/pbek/QOwnNotes/issues/3467))
+- Added an inline **Markdown LSP diagnostic context menu** section that appears
+  when right-clicking on a wave-underlined region in the note editor; it shows
+  the diagnostic message as a header and fetches available LSP code actions
+  (fixes) via a short synchronous wait, then lists each fix as a clickable menu
+  item — matching the same UX pattern used by the LanguageTool and Harper
+  context menus; the old standalone **Code actions** menu item in the
+  **Markdown LSP** submenu has been removed in favour of this inline approach
+  (for [#3467](https://github.com/pbek/QOwnNotes/issues/3467))
 - Fixed shortcuts not being saved or restored in the **Shortcuts** settings;
   `storeShortcutSettings` now iterates the actual menu actions (mirroring how
   `initShortcuts` reads them) and looks up the corresponding widgets in the

src/widgets/qownnotesmarkdowntextedit.cpp

@@ -14,6 +14,7 @@
 #include <QDragMoveEvent>
 #include <QDropEvent>
 #include <QEvent>
+#include <QEventLoop>
 #include <QFileInfo>
 #include <QFont>
 #include <QFontDatabase>
@@ -2538,11 +2539,6 @@ void QOwnNotesMarkdownTextEdit::onContextMenu(QPoint pos) {
         connect(formatSelectionAction, &QAction::triggered, this,
                 [this]() { requestMarkdownLspFormatting(true); });
 
-        QAction *codeActionsAction = lspMenu->addAction(tr("Code actions"));
-        codeActionsAction->setEnabled(isAllowNoteEditing && !_markdownLspDiagnostics.isEmpty());
-        connect(codeActionsAction, &QAction::triggered, this,
-                [this]() { requestMarkdownLspCodeActions(textCursor()); });
-
         menu->addSeparator();
     }
 
@@ -2694,6 +2690,8 @@ QMenu *QOwnNotesMarkdownTextEdit::spellCheckContextMenu(QPoint pos) {
     addHarperMenuSection(menu, cursorAtMouse, cursor, hasEntries);
 #endif
 
+    addMarkdownLspMenuSection(menu, cursorAtMouse, hasEntries);
+
     if (!spellchecker || !spellchecker->isActive() || _isSpellCheckingDisabled) {
         if (!hasEntries) {
             delete menu;
@@ -2800,6 +2798,95 @@ QMenu *QOwnNotesMarkdownTextEdit::spellCheckContextMenu(QPoint pos) {
     return menu;
 }
 
+void QOwnNotesMarkdownTextEdit::addMarkdownLspMenuSection(QMenu *menu,
+                                                          const QTextCursor &cursorAtMouse,
+                                                          bool &hasEntries) {
+    if (!_markdownLspEnabled || !_markdownLspClient || _markdownLspDiagnostics.isEmpty()) {
+        return;
+    }
+
+    // Find a diagnostic whose range covers the cursor position
+    const int cursorLine = cursorAtMouse.blockNumber();
+    const int cursorCol = cursorAtMouse.positionInBlock();
+    const MarkdownLspClient::Diagnostic *match = nullptr;
+    for (const auto &diag : std::as_const(_markdownLspDiagnostics)) {
+        if (cursorLine >= diag.range.startLine && cursorLine <= diag.range.endLine) {
+            // For single-line diagnostics also check column range
+            if (diag.range.startLine == diag.range.endLine) {
+                if (cursorCol >= diag.range.startCharacter &&
+                    cursorCol <= diag.range.endCharacter) {
+                    match = &diag;
+                    break;
+                }
+            } else {
+                match = &diag;
+                break;
+            }
+        }
+    }
+
+    if (!match) {
+        return;
+    }
+
+    // Add separator before LSP section if other entries already exist
+    if (hasEntries) {
+        menu->addSeparator();
+    }
+
+    // Show the diagnostic message as a disabled header
+    const QString header = tr("Markdown LSP: %1").arg(match->message);
+    QAction *headerAction = menu->addAction(header);
+    headerAction->setEnabled(false);
+
+    // Request code actions for this diagnostic and wait briefly for the response
+    // using a local event loop (same pattern as QDialog::exec)
+    MarkdownLspClient::DiagnosticRange range = match->range;
+    _markdownLspLastCodeActions.clear();
+    _markdownLspCodeActionRequestId =
+        _markdownLspClient->requestCodeActions(_markdownLspUri, range, {*match});
+
+    if (_markdownLspCodeActionRequestId >= 0) {
+        QVector<MarkdownLspClient::CodeAction> receivedActions;
+        int receivedId = -1;
+
+        // Wait up to 2 seconds for the response
+        QEventLoop loop;
+        QTimer timeout;
+        timeout.setSingleShot(true);
+        timeout.setInterval(2000);
+        connect(&timeout, &QTimer::timeout, &loop, &QEventLoop::quit);
+        connect(_markdownLspClient, &MarkdownLspClient::codeActionsReceived, &loop,
+                [&](int id, const QVector<MarkdownLspClient::CodeAction> &actions) {
+                    receivedId = id;
+                    receivedActions = actions;
+                    loop.quit();
+                });
+        timeout.start();
+        loop.exec();
+
+        if (receivedId == _markdownLspCodeActionRequestId) {
+            _markdownLspCodeActionRequestId = -1;
+            if (receivedActions.isEmpty()) {
+                QAction *noFixAction = menu->addAction(tr("No fixes available"));
+                noFixAction->setEnabled(false);
+            } else {
+                for (const auto &action : std::as_const(receivedActions)) {
+                    menu->addAction(action.title, this, [this, action]() {
+                        if (action.hasEdits()) {
+                            applyMarkdownLspTextEdits(action.edits);
+                        } else if (action.hasCommand()) {
+                            _markdownLspClient->executeCommand(action.command);
+                        }
+                    });
+                }
+            }
+        }
+    }
+
+    hasEntries = true;
+}
+
 #ifdef LANGUAGETOOL_ENABLED
 void QOwnNotesMarkdownTextEdit::addLanguageToolMenuSection(QMenu *menu,
                                                            const QTextCursor &cursorAtMouse,

src/widgets/qownnotesmarkdowntextedit.h

@@ -178,6 +178,7 @@ class QOwnNotesMarkdownTextEdit : public QMarkdownTextEdit {
     void overrideFontSizeStyle(int fontSize);
 
     QMenu *spellCheckContextMenu(QPoint pos);
+    void addMarkdownLspMenuSection(QMenu *menu, const QTextCursor &cursorAtMouse, bool &hasEntries);
 #ifdef LANGUAGETOOL_ENABLED
     void addLanguageToolMenuSection(QMenu *menu, const QTextCursor &cursorAtMouse,
                                     const QTextCursor &selectedCursor, bool &hasEntries);