Skip to content

Commit 9f91d2f

Browse files
committed
feat: add "+" button to add public links only for space managers
1 parent 7771bc6 commit 9f91d2f

File tree

2 files changed

+27
-3
lines changed

2 files changed

+27
-3
lines changed

owncloudApp/src/main/java/com/owncloud/android/presentation/spaces/members/SpaceMembersFragment.kt

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -215,9 +215,7 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
215215
when (val uiResult = event.peekContent()) {
216216
is UIResult.Success -> {
217217
uiResult.data?.let { spacePermissions ->
218-
binding.addMemberButton.isVisible = DRIVES_CREATE_PERMISSION in spacePermissions
219-
canRemoveMembers = DRIVES_DELETE_PERMISSION in spacePermissions
220-
canEditMembers = DRIVES_UPDATE_PERMISSION in spacePermissions
218+
checkPermissions(spacePermissions)
221219
spaceMembersAdapter.setSpaceMembers(spaceMembers, roles, canRemoveMembers, canEditMembers, numberOfManagers)
222220
}
223221
}
@@ -270,6 +268,17 @@ class SpaceMembersFragment : Fragment(), SpaceMembersAdapter.SpaceMembersAdapter
270268
}
271269
}
272270

271+
272+
private fun checkPermissions(spacePermissions: List<String>) {
273+
binding.apply {
274+
val hasCreatePermission = DRIVES_CREATE_PERMISSION in spacePermissions
275+
addMemberButton.isVisible = hasCreatePermission
276+
addPublicLinkButton.isVisible = hasCreatePermission
277+
}
278+
canRemoveMembers = DRIVES_DELETE_PERMISSION in spacePermissions
279+
canEditMembers = DRIVES_UPDATE_PERMISSION in spacePermissions
280+
}
281+
273282
private fun showOrHideEmptyView(hasLinks: Boolean) {
274283
binding.apply {
275284
publicLinksRecyclerView.isVisible = hasLinks

owncloudApp/src/main/res/layout/members_fragment.xml

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -103,6 +103,21 @@
103103
app:layout_constraintStart_toStartOf="parent"
104104
app:layout_constraintTop_toTopOf="parent"/>
105105

106+
<ImageButton
107+
android:id="@+id/add_public_link_button"
108+
android:layout_width="48dp"
109+
android:layout_height="48dp"
110+
android:padding="@dimen/standard_padding"
111+
android:background="@color/transparent"
112+
android:src="@drawable/ic_add"
113+
android:contentDescription="@string/content_description_add_public_link"
114+
android:visibility="gone"
115+
android:focusable="true"
116+
android:clickable="true"
117+
app:layout_constraintEnd_toEndOf="parent"
118+
app:layout_constraintTop_toTopOf="parent"
119+
tools:visibility="visible"/>
120+
106121
</androidx.constraintlayout.widget.ConstraintLayout>
107122

108123
<TextView

0 commit comments

Comments
 (0)