feat(cli): fixed code for copilote

Signed-off-by: olivier dubo <olivier.dubo@ovhcloud.com>

Author: duboolivier

internal/cmd/completion.go

@@ -67,6 +67,9 @@ To make completions permanent, run:
 
 func runCompletionInstall(_ *cobra.Command, _ []string) error {
 	shell := os.Getenv("SHELL")
+	if shell == "" {
+		return fmt.Errorf("SHELL environment variable is not set — please run 'ovhcloud completion bash|zsh|fish|powershell' manually")
+	}
 	shellName := filepath.Base(shell)
 
 	var rcFile string

internal/cmd/completion_test.go

@@ -150,3 +150,16 @@ func TestCompletionInstall_UnsupportedShell(t *testing.T) {
 		t.Errorf("unexpected error message: %v", err)
 	}
 }
+
+func TestCompletionInstall_EmptyShell(t *testing.T) {
+	setupHome(t)
+	t.Setenv("SHELL", "")
+
+	err := runCompletionInstall(nil, nil)
+	if err == nil {
+		t.Fatal("expected an error when SHELL is unset, got nil")
+	}
+	if !strings.Contains(err.Error(), "SHELL environment variable is not set") {
+		t.Errorf("unexpected error message: %v", err)
+	}
+}

internal/completion/completion.go

@@ -6,6 +6,7 @@ package completion
 
 import (
 	"fmt"
+	"net/url"
 	"strconv"
 	"time"
 
@@ -41,7 +42,9 @@ func fetchSuggestions(endpoint, labelField, cacheKey string) ([]string, cobra.Sh
 			return
 		}
 
-		var suggestions []string
+		// Start from a non-nil slice so a valid empty result is still cached
+		// (nil is reserved for the error path above, which must not be cached).
+		suggestions := make([]string, 0, len(ids))
 		for _, raw := range ids {
 			switch v := raw.(type) {
 			case string:
@@ -116,7 +119,7 @@ func CloudResources(pathTemplate string) func(*cobra.Command, []string, string)
 		if project == "" {
 			return nil, cobra.ShellCompDirectiveNoFileComp
 		}
-		return fetchSuggestions(fmt.Sprintf(pathTemplate, project), "", "")
+		return fetchSuggestions(fmt.Sprintf(pathTemplate, url.PathEscape(project)), "", "")
 	}
 }
 
@@ -133,9 +136,9 @@ func CloudResourceWithChild(parentTemplate, childTemplate string) func(*cobra.Co
 		}
 		switch len(args) {
 		case 0:
-			return fetchSuggestions(fmt.Sprintf(parentTemplate, project), "", "")
+			return fetchSuggestions(fmt.Sprintf(parentTemplate, url.PathEscape(project)), "", "")
 		case 1:
-			return fetchSuggestions(fmt.Sprintf(childTemplate, project, args[0]), "", "")
+			return fetchSuggestions(fmt.Sprintf(childTemplate, url.PathEscape(project), url.PathEscape(args[0])), "", "")
 		default:
 			return nil, cobra.ShellCompDirectiveNoFileComp
 		}