feat(dedicated.netapp): fix no replication destination services

ref: #MANAGER-18706

Signed-off-by: Quentin Pavy <quentin.pavy.ext@ovhcloud.com>

Author: Quentin Pavy

packages/manager/modules/netapp/src/dashboard/service.js

@@ -381,7 +381,4 @@ export default class NetAppDashboardService {
       });
   }
 
-  hasAvailableReplicationsServices() {
-    return !!this.replicationsAvaibleServices.length;
-  }
 }

packages/manager/modules/netapp/src/dashboard/volumes/component.js

@@ -24,6 +24,7 @@ export default {
     totalVolumesStorage: '<',
     goToCreateReplications: '<',
     replicationsAvaibleServices: '<',
+    hasAvailableReplicationsServices: '<',
     isNetworkAvailable: '<',
   },
   template,

packages/manager/modules/netapp/src/dashboard/volumes/controller.js

@@ -2,8 +2,6 @@ export default class {
   /* @ngInject */
   constructor(NetAppDashboardService) {
     this.NetAppDashboardService = NetAppDashboardService;
-    this.hasAvailableReplicationsServices =
-      NetAppDashboardService.hasAvailableReplicationsServices;
     this.selectedReplicationsCheckboxes = {};
     this.AWAITING_REPLICATION_STATUS = 'awaiting_replication';
   }

packages/manager/modules/netapp/src/dashboard/volumes/create-replications/component.js

@@ -4,6 +4,7 @@ import controller from './controller';
 export default {
   bindings: {
     replicationsAvaibleServices: '<',
+    hasAvailableReplicationsServices: '<',
     goToOrder: '<',
     goToVolumes: '<',
     postReplications: '<',

packages/manager/modules/netapp/src/dashboard/volumes/create-replications/controller.js

@@ -1,7 +1,6 @@
 export default class NetappVolumesCreateReplicationsCtrl {
-  /* @ngInject */ constructor(NetAppDashboardService, $translate) {
-    this.hasAvailableReplicationsServices =
-      NetAppDashboardService.hasAvailableReplicationsServices;
+  /* @ngInject */
+  constructor(NetAppDashboardService, $translate) {
     this.optionsReplicationsAvaibleServices = [];
     this.onPostLoad = false;
     this.replicationsSelectedVolumes =
@@ -61,7 +60,7 @@ export default class NetappVolumesCreateReplicationsCtrl {
   isPrimaryButtonDisabled() {
     return (
       this.onPostLoad ||
-      (this.hasAvailableReplicationsServices() && !this.destinationServiceId)
+      (this.hasAvailableReplicationsServices && !this.destinationServiceId)
     );
   }
 }

packages/manager/modules/netapp/src/dashboard/volumes/create-replications/template.html

@@ -2,14 +2,14 @@
     data-loading="$ctrl.onPostLoad"
     data-on-dismiss="$ctrl.goToVolumes()"
     data-heading="{{:: 'netapp_network_volumes_replications_title' | translate }}"
-    data-primary-label="{{:: !$ctrl.isNetworkAvailable && $ctrl.hasAvailableReplicationsServices() ? 'netapp_network_volumes_replications_button_sync' : 'netapp_network_volumes_replications_button_buy' | translate }}"
+    data-primary-label="{{:: !$ctrl.isNetworkAvailable && $ctrl.hasAvailableReplicationsServices ? 'netapp_network_volumes_replications_button_sync' : 'netapp_network_volumes_replications_button_buy' | translate }}"
     data-primary-action="$ctrl.onPrimaryClick()"
     data-secondary-label="{{:: 'netapp_network_volumes_replications_button_cancel' | translate }}"
     data-secondary-action="$ctrl.goToVolumes()"
     data-primary-disabled="$ctrl.isPrimaryButtonDisabled()"
 >
     <div
-        data-ng-if="!$ctrl.replicationsSelectedVolumes.length && $ctrl.hasAvailableReplicationsServices()"
+        data-ng-if="!$ctrl.replicationsSelectedVolumes.length && $ctrl.hasAvailableReplicationsServices"
     >
         <strong
             data-translate="netapp_network_volumes_no_selected_volume_replications_subtitle"
@@ -18,7 +18,7 @@
             data-translate="netapp_network_volumes_no_selected_volume_replications_description"
         ></p>
     </div>
-    <div data-ng-if="!$ctrl.hasAvailableReplicationsServices()">
+    <div data-ng-if="!$ctrl.hasAvailableReplicationsServices">
         <strong
             data-translate="netapp_network_volumes_no_replications_subtitle"
         ></strong>
@@ -27,7 +27,7 @@
         ></p>
     </div>
     <div
-        data-ng-if="$ctrl.hasAvailableReplicationsServices() && $ctrl.replicationsSelectedVolumes.length"
+        data-ng-if="$ctrl.hasAvailableReplicationsServices && $ctrl.replicationsSelectedVolumes.length"
     >
         <p data-translate="netapp_network_volumes_replications_description"></p>
         <p

packages/manager/modules/netapp/src/dashboard/volumes/routing.js

@@ -179,6 +179,8 @@ export default /* @ngInject */ ($stateProvider) => {
           )
           .then(({ data = [] }) => data)
           .catch(() => []),
+      hasAvailableReplicationsServices: /* @ngInject */ (replicationsAvaibleServices) =>
+        !!replicationsAvaibleServices.length
     },
     atInternet: {
       ignore: true,

packages/manager/modules/netapp/src/dashboard/volumes/template.html

@@ -22,7 +22,7 @@
         data-icon-left="oui-icon oui-icon-arrow-transfer"
         class="mr-2"
         ng-if="!$ctrl.isNetworkAvailable"
-        data-disabled="$ctrl.hasAvailableReplicationsServices() && !$ctrl.NetAppDashboardService.replicationsSelectedVolumes.length"
+        data-disabled="$ctrl.hasAvailableReplicationsServices && !$ctrl.NetAppDashboardService.replicationsSelectedVolumes.length"
     >
         <span data-translate="netapp_volumes_button_replications"></span>
     </oui-button>
@@ -38,7 +38,7 @@
                 data-ng-if="!$ctrl.isNetworkAvailable"
                 data-model="$ctrl.selectedReplicationsCheckboxes[$row.id]"
                 data-on-change="$ctrl.handleCheckboxChange({volumeId: $row.id, checked: modelValue})"
-                data-disabled="$row.status === $ctrl.AWAITING_REPLICATION_STATUS || !$ctrl.hasAvailableReplicationsServices()"
+                data-disabled="$row.status === $ctrl.AWAITING_REPLICATION_STATUS"
             ></oui-checkbox>
         </oui-datagrid-column>
         <oui-datagrid-column
@@ -99,7 +99,7 @@
                 <span data-translate="netapp_volumes_edit_volume"></span>
             </oui-action-menu-item>
             <oui-action-menu-item
-                data-ng-if="$ctrl.hasAvailableReplicationsServices() && !$ctrl.isNetworkAvailable"
+                data-ng-if="!$ctrl.isNetworkAvailable"
                 data-disabled="$row.status === $ctrl.AWAITING_REPLICATION_STATUS"
                 data-on-click="$ctrl.goToSingleReplication($row.id)"
             >