Skip to content

Commit f80057d

Browse files
committed
Migrate to signpath.io
1 parent 78e5a09 commit f80057d

File tree

3 files changed

+45
-81
lines changed

3 files changed

+45
-81
lines changed

.github/workflows/release.yaml

Lines changed: 45 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -40,16 +40,16 @@ jobs:
4040
fail-fast: false
4141
matrix:
4242
settings:
43-
- host: macos-latest
44-
target: universal-apple-darwin
45-
toolchain: aarch64-apple-darwin,x86_64-apple-darwin
46-
bundles: app,dmg
47-
os: darwin
48-
- host: windows-latest
49-
target: x86_64-pc-windows-msvc
50-
toolchain: x86_64-pc-windows-msvc
51-
bundles: msi,nsis
52-
os: windows
43+
# - host: macos-latest
44+
# target: universal-apple-darwin
45+
# toolchain: aarch64-apple-darwin,x86_64-apple-darwin
46+
# bundles: app,dmg
47+
# os: darwin
48+
# - host: windows-latest
49+
# target: x86_64-pc-windows-msvc
50+
# toolchain: x86_64-pc-windows-msvc
51+
# bundles: msi,nsis
52+
# os: windows
5353
- host: ubuntu-latest
5454
target: x86_64-unknown-linux-gnu
5555
toolchain: x86_64-unknown-linux-gnu
@@ -120,21 +120,41 @@ jobs:
120120
run: |
121121
ls -hal binaries
122122
sha1sum binaries/*
123-
- name: Sign Windows Binaries
124-
run: |
125-
echo "Starting code sign for windows bins..."
126-
docker run -v "./binaries:/code/binaries" ghcr.io/sslcom/codesigner:latest batch_sign \
127-
-username=${ES_USERNAME} \
128-
-password=${ES_PASSWORD} \
129-
-credential_id=${ES_CREDENTIAL_ID} \
130-
-totp_secret=${ES_TOTP_SECRET} \
131-
-input_dir_path="/code/binaries" \
132-
-output_dir_path="/code/binaries/signed"
133-
env:
134-
ES_USERNAME: "${{ secrets.ES_USERNAME }}"
135-
ES_PASSWORD: "${{ secrets.ES_PASSWORD }}"
136-
ES_CREDENTIAL_ID: "${{ secrets.ES_CREDENTIAL_ID }}"
137-
ES_TOTP_SECRET: "${{ secrets.ES_TOTP_SECRET }}"
123+
- name: upload-unsigned-artifact
124+
id: upload-unsigned-artifact
125+
uses: actions/upload-artifact@v4
126+
with:
127+
path: ./binaries
128+
# - name: Sign Windows Binaries
129+
# uses: signpath/[email protected]
130+
# with:
131+
# api-token: '${{ secrets.SIGNPATH_API_TOKEN }}'
132+
# organization-id: '<SignPath organization id>'
133+
# project-slug: '<SignPath project slug>'
134+
# signing-policy-slug: '<SignPath signing policy slug>'
135+
# github-artifact-id: '${{ steps.upload-unsigned-artifact.outputs.artifact-id }}'
136+
# wait-for-completion: true
137+
# output-artifact-directory: 'binaries/signed'
138+
# parameters: |
139+
# version: ${{ toJSON(some.userinput) }}
140+
# myparam: "another param"
141+
# FIXME: this was the old code
142+
# - name: Sign Windows Binaries
143+
# run: |
144+
# echo "Starting code sign for windows bins..."
145+
# docker run -v "./binaries:/code/binaries" ghcr.io/sslcom/codesigner:latest batch_sign \
146+
# -username=${ES_USERNAME} \
147+
# -password=${ES_PASSWORD} \
148+
# -credential_id=${ES_CREDENTIAL_ID} \
149+
# -totp_secret=${ES_TOTP_SECRET} \
150+
# -input_dir_path="/code/binaries" \
151+
# -output_dir_path="/code/binaries/signed"
152+
# env:
153+
# ES_USERNAME: "${{ secrets.ES_USERNAME }}"
154+
# ES_PASSWORD: "${{ secrets.ES_PASSWORD }}"
155+
# ES_CREDENTIAL_ID: "${{ secrets.ES_CREDENTIAL_ID }}"
156+
# ES_TOTP_SECRET: "${{ secrets.ES_TOTP_SECRET }}"
157+
138158
- name: Postsign
139159
run: |
140160
ls -hal binaries/signed

apps/desktop/sign.sh

Lines changed: 0 additions & 41 deletions
This file was deleted.

scripts/sign-windows.sh

Lines changed: 0 additions & 15 deletions
This file was deleted.

0 commit comments

Comments
 (0)