allow slug for draft l10ns in slugs_with_ancestor_slugs (#3916)

Author: SebouChu

app/models/communication/website/permalink.rb

@@ -38,6 +38,7 @@ class Communication::Website::Permalink < ApplicationRecord
 
   validates :path, presence: true
   validates :path, uniqueness: { scope: :website_id }, unless: :is_current
+  # TODO: validate :root_path_is_reserved_for_home
 
   before_validation :set_university, on: :create
   # We should not sync the about object whenever we do something with the permalink, as they can be changed during a sync.
@@ -187,4 +188,9 @@ def regenerate_website_hosting_config
     return unless website.persisted?
     website.regenerate_hosting_config!
   end
+
+  def root_path_is_reserved_for_home
+    return unless path == "/"
+    errors.add(:path, :reserved_for_home) unless about.about.is_a?(Communication::Website::Page::Home)
+  end
 end

app/models/concerns/as_localization.rb

@@ -67,13 +67,9 @@ def localize_in!(language)
   def slug_with_ancestors_slugs
     about.ancestors_and_self.map { |ancestor|
       l10n = ancestor.localization_for(language)
-      if l10n.nil? || l10n.try(:draft?)
-        # If l10n is nil or draft, no slug
-        nil
-      else
-        # otherwise (published or no publication state) we return the slug
-        l10n.slug
-      end
+      # If l10n is nil, no slug
+      # otherwise (published or not) we return the slug
+      l10n.try(:slug)
     }.compact_blank.join('/')
   end
 

config/locales/communication/en.yml

@@ -361,6 +361,7 @@ en:
             path:
               blank: must be correct, as defined by RFC2396
               not_unique: already used by another alias
+              reserved_for_home: is reserved for the home page
     models:
       communication/block:
         one: Content block

config/locales/communication/fr.yml

@@ -360,6 +360,7 @@ fr:
             path:
               blank: doit être un chemin correct, comme défini par la RFC2396
               not_unique: déjà utilisé par un autre alias
+              reserved_for_home: est réservé pour la page d'accueil
     models:
       communication/block:
         one: Bloc de contenu