'Git' extension assumes home directory is in `/home`

[cottsay]

This assumption is particularly broken when rocker is used by the root user.

rocker/src/rocker/git_extension.py

Line 41 in e2d3c4f

user_gitconfig_target = '/home/%(username)s/.gitconfig' % locals()

[cottsay]

Looks like the 'User' extension does the same:

rocker/src/rocker/extensions.py

Line 347 in e2d3c4f

substitutions['dir'] = os.path.join('/home/', cliargs['user_override_name'])

I believe the 'HomeDir' extension is working correctly, though:

rocker/src/rocker/extensions.py

Line 314 in e2d3c4f

return ' -v %s:%s ' % (Path.home(), Path.home())

[tfoote]

The newer implementation with Path.home() is probably the right thing to do. We'll need to double check if there's any extra logic about inside paths. But switching away from the hard coded paths is a definite step forward.

[tfoote]

Sorry looking into this more the git config only overrides the '/home' directory when you're using a target override user. Are you overriding the user to force it back to root?

[cottsay]

I'm just trying to run the tests.

Repro: https://gist.githubusercontent.com/cottsay/4360265b49b7e830c2b3de22b8978994/raw/Containerfile