Summary
analyze accepts an --offline flag, but cmd/optiqor/main.go comments it as "always true in Phase 1" and never reads its value. This is confusing: users who pass --offline expect a guarantee that no network calls will be made, but they get no signal that the flag did anything.
Steps to reproduce
optiqor analyze ./my-chart --offline
# No error, but the flag has no observable effect or documented guarantee.
What to do
- Locate the
--offline binding in cmd/optiqor/main.go (near the analyze command flags).
- Delete the "always true in Phase 1" comment and actually read the flag.
- If
--offline is set (or OPTIQOR_OFFLINE=1 env var), and --share is also set, print a warning:
warning: --share is ignored in --offline mode
and skip the upload without exiting non-zero.
- Document the flag clearly in
--help.
Acceptance criteria
--offline --share prints a warning and skips the upload instead of silently uploading.
OPTIQOR_OFFLINE=1 is honoured identically to --offline.
- The flag is documented in
optiqor analyze --help.
make lint test passes.
Why this is a good first issue
- Isolated change: only
cmd/optiqor/main.go and the --share upload path in internal/share/share.go.
- Good entry point to understanding how flags flow through the CLI.
Summary
analyzeaccepts an--offlineflag, butcmd/optiqor/main.gocomments it as "always true in Phase 1" and never reads its value. This is confusing: users who pass--offlineexpect a guarantee that no network calls will be made, but they get no signal that the flag did anything.Steps to reproduce
optiqor analyze ./my-chart --offline # No error, but the flag has no observable effect or documented guarantee.What to do
--offlinebinding incmd/optiqor/main.go(near theanalyzecommand flags).--offlineis set (orOPTIQOR_OFFLINE=1env var), and--shareis also set, print a warning:--help.Acceptance criteria
--offline --shareprints a warning and skips the upload instead of silently uploading.OPTIQOR_OFFLINE=1is honoured identically to--offline.optiqor analyze --help.make lint testpasses.Why this is a good first issue
cmd/optiqor/main.goand the--shareupload path ininternal/share/share.go.