Sometimes, cannot quit gracefully

[thinkAfCod]

Expected behaviour

When to kill, shisui could be quit with 100% certainty.

Actual behaviour

Sometimes, shisui cannot quit gracefully. And it may be blocked after printing the log:

if len(clientChan) == 0 {
	log.Warn("Waiting for the client to start...")
}
c := <-clientChan
c.closePortalRpcServer()

[r4f4ss]

@thinkAfCod I tried with different combination of parameters and I was not able to reproduce. Can you share the command/parameters you are using?

[thinkAfCod]

Here is my go version:

go version go1.22.6 linux/amd64

Here is the command for startup:

go run -tags shisui ./cmd/shisui/main.go \
--nat stun \
--loglevel 5 \
--udp.port 10001 \
--rpc.addr 0.0.0.0 --rpc.port 11001 \
--pprof --pprof.addr=65.109.69.98 --pprof.port=12001 \
--data.dir shisui_node1 \
--networks state,history

[thinkAfCod]

I modified the code to try to fix the bug:

go func() {
	for {
		select {
		case c, ok := <-clientChan:
			if !ok {
				break
			}
			c.closePortalRpcServer()
		default:
			log.Warn("Waiting for the client to start...")
			time.Sleep(time.Second)
		}
	}
}()