UCT/IB: Add auto to the list of DEVX objects#11365
UCT/IB: Add auto to the list of DEVX objects#11365tvegas1 wants to merge 1 commit intoopenucx:masterfrom
Conversation
| {"MLX5_DEVX_OBJECTS", "rcqp,rcsrq,dct,dcsrq,dci,cq", | ||
| {"MLX5_DEVX_OBJECTS", "rcqp,rcsrq,dct,dcsrq,dci,cq,auto", | ||
| "Objects to be created by DEVX\n", | ||
| ucs_offsetof(uct_ib_md_config_t, devx_objs), | ||
| UCS_CONFIG_TYPE_BITMAP(uct_ib_devx_objs)}, |
There was a problem hiding this comment.
Maybe we can extend the config type to accept auto? Or create a dedicated config type for that?
There was a problem hiding this comment.
AFAIU it is already added in #11010, just that parser did not allow it.
There was a problem hiding this comment.
Yes, what I meant was that CONFIG_TYPE_BITMAP or CONFIG_TYPE_BITMAP_AUTO will allow auto value under the hood, so there will be no need to list it as a devx object; the config type will imply it.
There was a problem hiding this comment.
It looks like "auto" is just one of the bitmap values so why treat it differently in the parser?
static const char *uct_ib_devx_objs[] = {
[UCT_IB_DEVX_OBJ_RCQP] = "rcqp",
[UCT_IB_DEVX_OBJ_RCSRQ] = "rcsrq",
[UCT_IB_DEVX_OBJ_DCT] = "dct",
[UCT_IB_DEVX_OBJ_DCSRQ] = "dcsrq",
[UCT_IB_DEVX_OBJ_DCI] = "dci",
[UCT_IB_DEVX_OBJ_CQ] = "cq",
[UCT_IB_DEVX_OBJ_AUTO] = "auto",
NULL
};
The only thing I can suggest is to have a parser that checks directly with the values of uct_ib_devx_objs instead of the currently separate values string "rcqp,rcsrq,dct,dcsrq,dci,cq,auto"
There was a problem hiding this comment.
wait, need to rework that pr.
|
modified list in this PR is actually the default flag list. it does not make sense to add auto here, original issue is actually a setup issue where a ucx.conf with auto is used with older library. |
What?
Add
autoto the list of DEVX objects. This configuration is used on Grace primarily (#11010).Why?
Fixes parser issue: