replace sinon with vitest's built in spy/mock library

fixes an incompatibility between the newly added `ChaiStyleAssertions` by vitest v4.1, and the `sinon-chai` plugin we used previously

closes #12056

Author: tyrasd

CHANGELOG.md

@@ -47,6 +47,9 @@ _Breaking developer changes, which may affect downstream projects or sites that
 #### :hourglass: Performance
 #### :mortar_board: Walkthrough / Help
 #### :hammer: Development
+* Replace `sinon` with `vitest`'s built in spy/mock library ([#12058])
+
+[#12058]: https://github.com/openstreetmap/iD/pull/12058
 
 
 # 2.39.2

package-lock.json

@@ -135,8 +135,6 @@
     "serve-handler": "^6.1.6",
     "shelljs": "^0.10.0",
     "shx": "^0.4.0",
-    "sinon": "^21.0.0",
-    "sinon-chai": "^4.0.1",
     "svg-sprite": "2.0.4",
     "typescript": "^5.9.3",
     "typescript-eslint": "^8.56.0",

package.json

@@ -1,3 +1,4 @@
+import { fn } from '@vitest/spy';
 import { setTimeout } from 'node:timers/promises';
 import { clear } from 'idb-keyval';
 import { asyncPrefs } from '../../../modules/core/preferences';
@@ -14,7 +15,7 @@ describe('iD.coreHistory', function () {
     beforeEach(function () {
         context = iD.coreContext().assetPath('../dist/').init();
         history = context.history();
-        spy = sinon.spy();
+        spy = fn();
     });
 
     describe('#graph', function () {
@@ -57,13 +58,12 @@ describe('iD.coreHistory', function () {
         it('emits a change event', function () {
             history.on('change', spy);
             var difference = history.perform(actionNoop);
-            expect(spy).to.have.been.calledWith(difference);
-            expect(spy.callCount).to.eql(1);
+            expect(spy).to.have.been.calledOnceWith(difference);
         });
 
         it('performs multiple actions', function () {
-            var action1 = sinon.stub().returns(iD.coreGraph());
-            var action2 = sinon.stub().returns(iD.coreGraph());
+            const action1 = fn().mockReturnValue(iD.coreGraph());
+            const action2 = fn().mockReturnValue(iD.coreGraph());
             history.perform(action1, action2, 'annotation');
             expect(action1).to.have.been.called;
             expect(action2).to.have.been.called;
@@ -76,7 +76,7 @@ describe('iD.coreHistory', function () {
             history.on('change', spy);
             await history.perform(action1);
             await setTimeout(300);
-            expect(spy.callCount).to.be.above(2);
+            expect(spy.mock.calls.length).to.be.above(2);
         });
     });
 
@@ -104,8 +104,8 @@ describe('iD.coreHistory', function () {
         });
 
         it('performs multiple actions', function () {
-            var action1 = sinon.stub().returns(iD.coreGraph());
-            var action2 = sinon.stub().returns(iD.coreGraph());
+            const action1 = fn().mockReturnValue(iD.coreGraph());
+            const action2 = fn().mockReturnValue(iD.coreGraph());
             history.replace(action1, action2, 'annotation');
             expect(action1).to.have.been.called;
             expect(action2).to.have.been.called;

test/spec/core/history.js

@@ -1,3 +1,5 @@
+import { spyOn } from '@vitest/spy';
+
 describe('iD.presetField', function() {
     describe('#references', function() {
         it('references label and terms of another field', function() {
@@ -8,15 +10,15 @@ describe('iD.presetField', function() {
             allFields.preset = field;
 
             // mock localizer
-            sinon.spy(other, 't');
-            sinon.spy(field, 't');
+            spyOn(other, 't');
+            spyOn(field, 't');
 
             field.title();
             expect(other.t).to.have.been.calledOnce;
             expect(field.t).not.to.have.been.called;
 
-            other.t.resetHistory();
-            field.t.resetHistory();
+            other.t.mockClear();
+            field.t.mockClear();
 
             field.terms();
             expect(other.t).to.have.been.calledOnce;
@@ -31,8 +33,8 @@ describe('iD.presetField', function() {
             allFields.preset = field;
 
             // mock localizer
-            sinon.spy(other, 't');
-            sinon.spy(field, 't');
+            spyOn(other, 't');
+            spyOn(field, 't');
 
             field.placeholder();
             expect(other.t).to.have.been.calledOnce;
@@ -47,9 +49,9 @@ describe('iD.presetField', function() {
             allFields.preset = field;
 
             // mock localizer
-            sinon.spy(other.t, 'append');
-            sinon.spy(field.t, 'append');
-            sinon.stub(other, 'hasTextForStringId').returns(true);
+            spyOn(other.t, 'append');
+            spyOn(field.t, 'append');
+            spyOn(other, 'hasTextForStringId').mockReturnValue(true);
 
             var context = iD.coreContext().assetPath('../dist/').init();
             var uiField = iD.uiFieldCombo(field, context);