Skip to content

Commit dc2d733

Browse files
committed
OCPBUGS-66345: Fix broken API exports
1 parent 4524864 commit dc2d733

File tree

5 files changed

+38
-8
lines changed

5 files changed

+38
-8
lines changed

frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-core.md

Lines changed: 10 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -10,16 +10,20 @@ For current development version of Console, use `4.x.0-prerelease.n` packages.
1010
For older 1.x plugin SDK packages, refer to "OpenShift Console Versions vs SDK Versions" compatibility
1111
table in [Console dynamic plugins README](./README.md).
1212

13-
## 4.21.0-prerelease.x - TBD
13+
## 4.21.0-prerelease.1 - TBD
1414

15-
- Deprecated `setPluginStore` function in `k8s-utils.ts`. The function is now a noop and the export
15+
- **Deprecated**: `setPluginStore` function in `k8s-utils.ts`. The function is now a noop and the export
1616
will be removed in a future release. ([CONSOLE-4840], [#15671])
17-
- Fix `popupComponent` prop type in extension `console.dashboards/overview/health/resource` ([CONSOLE-4796], [#15526])
18-
- Begin alignment of plugin SDK types with `@openshift/dynamic-plugin-sdk` ([CONSOLE-3769], [#15509])
17+
- **Type breaking**: Fix `popupComponent` prop type in extension `console.dashboards/overview/health/resource` ([CONSOLE-4796], [#15526])
18+
- **Type breaking**: `AlwaysOnExtension` and `ModelDefinition` types are removed from `api/common-types`. ([CONSOLE-3769], [#15509])
19+
- The following types are now re-exported from `@openshift/dynamic-plugin-sdk` instead of being defined
20+
locally: `ExtensionFlags`, `ExtensionTypeGuard`, `ResolvedCodeRefProperties`, `RemoteEntryModule`, and `Update`. ([CONSOLE-4840], [#15509], [#15671])
1921
- Add optional `fetch` property to extension `console.dashboards/overview/health/url` ([CONSOLE-4796], [#15526])
2022
- Add optional `infrastructure` parameter to `PrometheusHealthHandler` type ([CONSOLE-4796], [#15526])
2123
- Allow `K8sResourceKind` in `TopologyDataObject`, `TopologyResourcesObject`, and `OverviewItem` types ([CONSOLE-4840], [#15699])
2224
- Allow async functions for the `resources` property of `console.topology/data/factory` extension ([CONSOLE-4806], [#15641])
25+
- Add color theme and font size customization to `ResourceYAMLEditor` component ([CONSOLE-4701], [#15735])
26+
- Ensure proper pass-through of `props.editorProps.theme` and `props.options.fontFamily` to `CodeEditor` component ([CONSOLE-4701], [#15735])
2327

2428
## 4.20.0 - 2025-11-24
2529

@@ -145,6 +149,7 @@ table in [Console dynamic plugins README](./README.md).
145149
[CONSOLE-4576]: https://issues.redhat.com/browse/CONSOLE-4576
146150
[CONSOLE-4654]: https://issues.redhat.com/browse/CONSOLE-4654
147151
[CONSOLE-4656]: https://issues.redhat.com/browse/CONSOLE-4656
152+
[CONSOLE-4701]: https://issues.redhat.com/browse/CONSOLE-4701
148153
[CONSOLE-4796]: https://issues.redhat.com/browse/CONSOLE-4796
149154
[CONSOLE-4806]: https://issues.redhat.com/browse/CONSOLE-4806
150155
[CONSOLE-4840]: https://issues.redhat.com/browse/CONSOLE-4840
@@ -212,3 +217,4 @@ table in [Console dynamic plugins README](./README.md).
212217
[#15641]: https://github.com/openshift/console/pull/15641
213218
[#15671]: https://github.com/openshift/console/pull/15671
214219
[#15699]: https://github.com/openshift/console/pull/15699
220+
[#15735]: https://github.com/openshift/console/pull/15735

frontend/packages/console-dynamic-plugin-sdk/CHANGELOG-webpack.md

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ For current development version of Console, use `4.x.0-prerelease.n` packages.
1010
For older 1.x plugin SDK packages, refer to "OpenShift Console Versions vs SDK Versions" compatibility
1111
table in [Console dynamic plugins README](./README.md).
1212

13+
## 4.21.0-prerelease.1 - 202x-xx-xx
14+
15+
- Remove usage of direct `webpack` imports in favor of `compiler.webpack` ([OCPBUGS-66345], [#15802])
16+
1317
## 4.20.0 - 2025-11-24
1418

1519
> Initial release for OCP Console 4.20.
@@ -98,6 +102,7 @@ table in [Console dynamic plugins README](./README.md).
98102
[OCPBUGS-53030]: https://issues.redhat.com/browse/OCPBUGS-53030
99103
[OCPBUGS-55323]: https://issues.redhat.com/browse/OCPBUGS-55323
100104
[OCPBUGS-61569]: https://issues.redhat.com/browse/OCPBUGS-61569
105+
[OCPBUGS-66345]: https://issues.redhat.com/browse/OCPBUGS-66345
101106
[#13188]: https://github.com/openshift/console/pull/13188
102107
[#13388]: https://github.com/openshift/console/pull/13388
103108
[#13521]: https://github.com/openshift/console/pull/13521
@@ -115,3 +120,4 @@ table in [Console dynamic plugins README](./README.md).
115120
[#14993]: https://github.com/openshift/console/pull/14993
116121
[#15183]: https://github.com/openshift/console/pull/15183
117122
[#15479]: https://github.com/openshift/console/pull/15479
123+
[#15802]: https://github.com/openshift/console/pull/15802
Lines changed: 18 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,18 @@
1+
import * as coreApi from '../core-api';
2+
import * as internalApi from '../internal-api';
3+
4+
describe('@openshift-console/dynamic-plugin-sdk core API', () => {
5+
Object.entries(coreApi).forEach(([exportName, exportValue]) => {
6+
it(`${exportName} should not be falsy`, () => {
7+
expect(exportValue).toBeDefined();
8+
});
9+
});
10+
});
11+
12+
describe('@openshift-console/dynamic-plugin-sdk-internal internal API', () => {
13+
Object.entries(internalApi).forEach(([exportName, exportValue]) => {
14+
it(`${exportName} should not be falsy`, () => {
15+
expect(exportValue).toBeDefined();
16+
});
17+
});
18+
});

frontend/packages/console-dynamic-plugin-sdk/src/api/internal-api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,7 @@ export const UtilizationItem: React.FC<UtilizationItemProps> = require('@console
5656
.default;
5757

5858
export const UtilizationBody: React.FC<UtilizationBodyProps> = require('@console/shared/src/components/dashboard/utilization-card/UtilizationBody')
59-
.default;
59+
.UtilizationBody;
6060

6161
export const UtilizationDurationDropdown: React.FC<UtilizationDurationDropdownProps> = require('@console/shared/src/components/dashboard/utilization-card/UtilizationDurationDropdown')
6262
.UtilizationDurationDropdown;
@@ -68,7 +68,7 @@ export const LazyActionMenu: React.FC<LazyActionMenuProps> = require('@console/s
6868
.default;
6969

7070
export const QuickStartsLoader: React.FC<QuickStartsLoaderProps> = require('@console/app/src/components/quick-starts/loader/QuickStartsLoader')
71-
.default;
71+
.QuickStartsLoader;
7272

7373
export const useUtilizationDuration: UseUtilizationDuration = require('@console/shared/src/hooks/useUtilizationDuration')
7474
.useUtilizationDuration;

frontend/packages/console-dynamic-plugin-sdk/src/api/internal-topology-api.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,8 +63,8 @@ export const getTopologyNodeItem: GetTopologyNodeItem = require('@console/topolo
6363
export const mergeGroup: MergeGroup = require('@console/topology/src/data-transforms/transform-utils')
6464
.mergeGroup;
6565

66-
export const getModifyApplicationAction: GetModifyApplicationAction = require('@console/topology/src/actions/modify-application')
67-
.getModifyApplicationAction;
66+
export const useGetModifyApplicationAction: GetModifyApplicationAction = require('@console/topology/src/actions/modify-application')
67+
.useGetModifyApplicationAction;
6868

6969
export const baseDataModelGetter: BaseDataModelGetter = require('@console/topology/src/data-transforms/data-transformer')
7070
.baseDataModelGetter;

0 commit comments

Comments
 (0)