fix: use browser.kill after report processing

Author: Subhra264

src/lib.rs

@@ -16,7 +16,11 @@
 pub mod config;
 pub mod router;
 
-use chromiumoxide::{browser::Browser, cdp::browser_protocol::page::PrintToPdfParams, Page};
+use chromiumoxide::{
+    browser::Browser,
+    cdp::browser_protocol::page::{CaptureScreenshotParamsBuilder, PrintToPdfParams},
+    Page,
+};
 use config::{get_chrome_launch_options, CONFIG};
 use futures::StreamExt;
 use lettre::{
@@ -165,9 +169,13 @@ pub async fn generate_report(
         }
         Err(e) => {
             let page_url = page.url().await;
+            // Take a screenshot before killing the browser to help debug login issues
+            take_screenshot(&page, org_id, dashboard_id).await?;
+            log::info!("killing browser");
             browser.close().await?;
             browser.wait().await?;
             handle.await?;
+            browser.kill().await;
             let err_msg = format!(
                 "Error finding email input box: current url: {:#?} error: {e}",
                 page_url
@@ -189,9 +197,12 @@ pub async fn generate_report(
         }
         Err(e) => {
             let page_url = page.url().await;
+            take_screenshot(&page, org_id, dashboard_id).await?;
+            log::info!("killing browser");
             browser.close().await?;
             browser.wait().await?;
             handle.await?;
+            browser.kill().await;
             let err_msg = format!(
                 "Error finding password input box: current url: {:#?} error: {e}",
                 page_url
@@ -285,9 +296,13 @@ pub async fn generate_report(
         .await
     {
         let page_url = page.url().await;
+        // Take a screenshot before killing the browser to help debug issues
+        take_screenshot(&page, org_id, dashboard_id).await?;
+        log::info!("killing browser");
         browser.close().await?;
         browser.wait().await?;
         handle.await?;
+        browser.kill().await;
         log::error!(
             "Error navigating to organization {org_id}: current uri: {:#?} error: {e}",
             page_url
@@ -302,9 +317,12 @@ pub async fn generate_report(
 
     if let Err(e) = page.goto(&dashb_url).await {
         let page_url = page.url().await;
+        take_screenshot(&page, org_id, dashboard_id).await?;
+        log::info!("killing browser");
         browser.close().await?;
         browser.wait().await?;
         handle.await?;
+        browser.kill().await;
         log::error!(
             "Error navigating to dashboard url {dashb_url}: current uri: {:#?} error: {e}",
             page_url
@@ -335,19 +353,27 @@ pub async fn generate_report(
 
     if let Err(e) = page.find_element("main").await {
         let page_url = page.url().await;
+        take_screenshot(&page, org_id, dashboard_id).await?;
+        // Take a screenshot before killing the browser to help debug login issues
+        log::info!("killing browser");
         browser.close().await?;
         browser.wait().await?;
         handle.await?;
+        browser.kill().await;
         return Err(anyhow::anyhow!(
             "[REPORT] main html element not rendered yet for dashboard {dashboard_id}; most likely login failed: current url: {:#?} error: {e}",
             page_url
         ));
     }
     if let Err(e) = page.find_element("div.displayDiv").await {
         let page_url = page.url().await;
+        // Take a screenshot before killing the browser to help debug login issues
+        take_screenshot(&page, org_id, dashboard_id).await?;
+        log::info!("killing browser");
         browser.close().await?;
         browser.wait().await?;
         handle.await?;
+        browser.kill().await;
         return Err(anyhow::anyhow!(
             "[REPORT] div.displayDiv element not rendered yet for dashboard {dashboard_id}: current url: {:#?} error: {e}",
             page_url
@@ -373,6 +399,7 @@ pub async fn generate_report(
     browser.close().await?;
     browser.wait().await?;
     handle.await?;
+    browser.kill().await;
     log::debug!("done with headless browser");
     Ok((pdf_data, email_dashb_url))
 }
@@ -430,6 +457,22 @@ async fn send_email(
     }
 }
 
+async fn take_screenshot(
+    page: &Page,
+    org_id: &str,
+    dashboard_name: &str,
+) -> Result<(), anyhow::Error> {
+    let timestamp = chrono::Utc::now().timestamp();
+    let screenshot_params = CaptureScreenshotParamsBuilder::default();
+    let screenshot = page.screenshot(screenshot_params.build()).await?;
+    tokio::fs::write(
+        format!("screenshot_{}_{}_{}.png", org_id, dashboard_name, timestamp),
+        &screenshot,
+    )
+    .await?;
+    Ok(())
+}
+
 pub async fn wait_for_panel_data_load(page: &Page) -> Result<Duration, anyhow::Error> {
     let start = std::time::Instant::now();
     let timeout = std::time::Duration::from_secs(CONFIG.chrome.chrome_sleep_secs.into());
@@ -456,6 +499,12 @@ pub async fn wait_for_panel_data_load(page: &Page) -> Result<Duration, anyhow::E
 fn sanitize_filename(filename: &str) -> String {
     filename
         .chars()
-        .map(|c| if c.is_ascii_alphanumeric() || c == '-' || c == '_' || c == ' ' { c } else { '_' })
+        .map(|c| {
+            if c.is_ascii_alphanumeric() || c == '-' || c == '_' || c == ' ' {
+                c
+            } else {
+                '_'
+            }
+        })
         .collect()
-}
+}