Skip to content

Commit 8d1dd35

Browse files
arfonxuanxu
authored andcommitted
Only respond with an emoji (eyes) when it makes sense
1 parent 6df0816 commit 8d1dd35

8 files changed

+8
-9
lines changed

app/responders/check_references_responder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def process_message(message)
1313
if target_repo_value.empty?
1414
respond("I couldn't find the URL for the target repository")
1515
else
16-
react_to_comment
16+
react_to_comment("eyes")
1717
DOIWorker.perform_async(serializable(locals), target_repo_value, branch_name_value)
1818
end
1919
end

app/responders/external_service_responder.rb

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,6 @@ def define_listening
1313

1414
def process_message(message)
1515
respond(params[:message]) if params[:message]
16-
react_to_comment
1716
ExternalServiceWorker.perform_async(serializable(params), serializable(locals))
1817
end
1918

app/responders/github_action_responder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -30,7 +30,7 @@ def process_message(message)
3030
parameters = {}.merge(inputs, mapped_parameters)
3131

3232
if trigger_workflow(workflow_repo, workflow_name, parameters, ref)
33-
react_to_comment
33+
react_to_comment("eyes")
3434
respond(params[:message]) if params[:message]
3535
process_labeling
3636
end

app/responders/repo_checks_responder.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ def process_message(message)
1313
if target_repo_value.empty?
1414
respond("I couldn't find the URL for the target repository")
1515
else
16-
react_to_comment
16+
react_to_comment("eyes")
1717
RepoChecksWorker.perform_async(serializable(locals), target_repo_value, branch_name_value, serializable(params[:checks]))
1818
end
1919
end

spec/responders/check_references_responder_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@
4040

4141
it "should react to the comment when dispatching worker" do
4242
@responder.context.issue_body += "<!--target-repository-->PAPERURL<!--end-target-repository-->"
43-
expect(@responder).to receive(:react_to_comment)
43+
expect(@responder).to receive(:react_to_comment).with("eyes")
4444
@responder.process_message("@botsci check references")
4545
end
4646

spec/responders/external_service_responder_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@
5353
expect { @responder.process_message("") }.to change(ExternalServiceWorker.jobs, :size).by(1)
5454
end
5555

56-
it "should react to the comment" do
57-
expect(@responder).to receive(:react_to_comment)
56+
it "should not react to the comment" do
57+
expect(@responder).to_not receive(:react_to_comment)
5858
@responder.process_message("")
5959
end
6060

spec/responders/github_action_responder_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@
7979
end
8080

8181
it "should react to the comment when workflow is triggered" do
82-
expect(@responder).to receive(:react_to_comment)
82+
expect(@responder).to receive(:react_to_comment).with("eyes")
8383
@responder.process_message("")
8484
end
8585

spec/responders/repo_checks_responder_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@
4343
end
4444

4545
it "should react to the comment when dispatching worker" do
46-
expect(@responder).to receive(:react_to_comment)
46+
expect(@responder).to receive(:react_to_comment).with("eyes")
4747
@responder.process_message("@botsci check repository")
4848
end
4949

0 commit comments

Comments
 (0)