Lobby UI should show actual join status instead of turning green unconditionally.

[mozboz]

Is your feature request related to a problem? Please describe.
When using the lobby to join a game, the large button immediately turns green which is visual feedback that your join request was successful - i.e. you've joined a game. However on many occasions the game doesn't actually start (e.g. because game was full?). The UI should not turn the button green until you have actually successfully joined a game.

Describe the solution you'd like
The button should only turn green when the server has successfully assigned you to a game. There could be text feedback available somewhere with a very simple message like 'Joining...' > 'Joined!', 'Failed - Full', etc.

Describe alternatives you've considered, Additional context
The current single lobby view is very simple compared to other multiplayer online games. Perhaps in future a player would be given a choice of games they can join. Feature development here seems like it should go carefully in terms of going towards that instead of building other standalone features that aren't getting closer to a lobby-view that supports more choice and other features.

[mozboz]

I'm new to OpenFront code base but interested in working on this. I had a quick look and found in lobbyClicked() in PublicLobby.ts, the style is set and then a join-lobby event fired. Haven't found where this is defined yet.

EDIT: More code exploration notes related to this feature. For my ref but maybe useful to others:

• Events join-lobby, leave-lobby are defined in Main.ts. join-lobby
• Main.ts then calls join-lobby in ClientGameRunner which does the actual work of connecting the local game state and local eventbus to the server via a ws connection.
• When the server's full (here in GameServer.ts, it sends an error message back to the client, stops what it's doing initialising that client in the game but does not close the connection.
• The server does close the connection to clients, e.g. when they're kicked
• When the client receives the full message, it calls the UI leave lobby, which only then closes the connection calling leave-lobby . The same code is run client side when receiving the full message as when the user clicks the button again to leave the lobby.

[mozboz]

Possible first dev question on this issue is, if when full (and in other cases, like when the client has previously been kicked) we can close the ws connection on the server side with an error message. This is possibly better anyway, as it looks like there are many ways that ws connections end up connected but unused, but no idea if there are other valid cases for this, e.g. spectators?