error message: inserting generation values

[peterdudfield]

When i insert the same generation values into the database, i get the following message

Error in the forecast pipeline: (<Status.INVALID_ARGUMENT: 3>, 'Invalid observation values. Ensure the values are greater than zero and less than 110%.', None)

Infact, this is due to a duplicate key in the obs.observed_generation table

[devsjc]

What duplicate key? What are the values that you are trying to insert that are failing?

[peterdudfield]

I think it was duplicate observation values, i.e. the same timestamp

[devsjc]

Ah yes that makes sense. Is this not desired behaviour?

[peterdudfield]

Yea, we should not entered duplicated observations.

But the error message I got back, said something different and that confused me. So potentially the error message could be updated

[devsjc]

I could also just add ON CONFLICT DO NOTHING which would prevent insertion as before but not raise an error?

[peterdudfield]

I think that would be good, thats what's done in the site-datamodel.
This means it will be a lighter load on the database, as we dont need to go and get old values

[devsjc]

Does this also remove the need for GetLatestObservations?

[peterdudfield]

Yea, I dont think we need that, as we have have GetObservationsAsTimeseriesRequest

[devsjc]

ON CONFLICT DO NOTHING now exists in CreateObservations as well.