fix(eulerr): replace external URL dependency with self-contained data; fix fills/col length errors#293
Closed
Copilot wants to merge 2 commits into
Closed
fix(eulerr): replace external URL dependency with self-contained data; fix fills/col length errors#293Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Agent-Logs-Url: https://github.com/openbiox/Bizard/sessions/df392943-ab57-4ac1-a8db-a5bb81155e41 Co-authored-by: ShixiangWang <25057508+ShixiangWang@users.noreply.github.com>
Agent-Logs-Url: https://github.com/openbiox/Bizard/sessions/df392943-ab57-4ac1-a8db-a5bb81155e41 Co-authored-by: ShixiangWang <25057508+ShixiangWang@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
ShixiangWang
May 2, 2026 08:59
View session
Member
|
不能通过减少依赖来解决实际问题 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
051-eulerr.qmdfetched example data fromhttps://hiplot.cn/ui/basic/eulerr/data.json— that endpoint's data changed, causingeulerr::plot.euler()to throwfills$fill must have length 1, n_sets, or n_subsets. Additionally,labels$colandquantities$colboth usedlength(genes)(total entries incl. intersections) instead of the correct per-argument lengths.Changes
data.table/jsonlitedependenciesfills$fill: Changedfill[seq_len(n_sets)]→rep_len(fill_colors, n_sets)— correct length and safe for any number of setslabels$col: Fixed torep("white", n_sets)(one per set label)quantities$col: Fixed torep("white", n_subsets)(one per Euler region)Contributors/审核author entries; applied all fixes to.zh.qmd