Small fixes to the project setup (#712)

* feat: add minio-data to gitignore

* feat: add current nvmrc to github action for deployment

* fix: add missing quotes to env example

* fix: remove spaces?

Author: scheidtdav

.env.example

@@ -32,9 +32,9 @@ SMTP_SECURE = "false"
 SMTP_USERNAME = "ignored"
 SMTP_PASSWORD = "ignored"
 
-S3_ENDPOINT=http://localhost:9000
-S3_REGION=eu-norht-1
-S3_BUCKET=device-images
-S3_ACCESS_KEY=minioadmin
-S3_SECRET_KEY=minioadmin123
-S3_PUBLIC_URL=http://localhost:9000/device-images
+S3_ENDPOINT="http://localhost:9000"
+S3_REGION="eu-north-1"
+S3_BUCKET="device-images"
+S3_ACCESS_KEY="minioadmin"
+S3_SECRET_KEY="minioadmin123"
+S3_PUBLIC_URL="http://localhost:9000/device-images"

.github/workflows/deploy.yml

@@ -131,6 +131,11 @@ jobs:
         with:
           images: ghcr.io/opensensemap/frontend
 
+      - name: 👓 Read .nvmrc
+        id: nvmrc
+        run: |
+          echo "NODE_VERSION=$(cat .nvmrc)" >> $GITHUB_OUTPUT
+
       - name: 🔑 GitHub Registry Auth
         uses: docker/login-action@v3
         with:
@@ -148,6 +153,7 @@ jobs:
           labels: ${{ steps.meta.outputs.labels }}
           build-args: |
             COMMIT_SHA=${{ github.sha }}
+            NODE_VERSION=${{ steps.nvmrc.outputs.NODE_VERSION }}
           cache-from: type=local,src=/tmp/.buildx-cache
           cache-to: type=local,mode=max,dest=/tmp/.buildx-cache-new
 

.gitignore

@@ -22,4 +22,6 @@ measurements.csv
 
 .react-router/
 
-/coverage
+/coverage
+
+/minio-data

.nvmrc

@@ -1 +1 @@
-v24.4.1
+24.4.1

other/Dockerfile

@@ -1,5 +1,7 @@
+ARG NODE_VERSION=current
+
 # base node image
-FROM node:22-bullseye-slim AS base
+FROM node:${NODE_VERSION}-slim AS base
 
 # set for base and all layer that inherit from it
 ENV NODE_ENV=production