PatchRecordComponent: Match Identical Types

ax3l · ax3l · commit 085ef1c52ff4 · 2026-01-25T23:22:28.000-08:00
diff --git a/include/openPMD/backend/PatchRecordComponent.hpp b/include/openPMD/backend/PatchRecordComponent.hpp
@@ -160,7 +160,10 @@ template <typename T>
 inline void PatchRecordComponent::store(uint64_t idx, T data)
 {
     Datatype dtype = determineDatatype<T>();
-    if (dtype != getDatatype())
+    if (dtype != getDatatype() && !isSameInteger<T>(getDatatype()) &&
+        !isSameFloatingPoint<T>(getDatatype()) &&
+        !isSameComplexFloatingPoint<T>(getDatatype()) &&
+        !isSameChar<T>(getDatatype()))
     {
         std::ostringstream oss;
         oss << "Datatypes of patch data (" << dtype << ") and dataset ("
@@ -187,7 +190,10 @@ template <typename T>
 inline void PatchRecordComponent::store(T data)
 {
     Datatype dtype = determineDatatype<T>();
-    if (dtype != getDatatype())
+    if (dtype != getDatatype() && !isSameInteger<T>(getDatatype()) &&
+        !isSameFloatingPoint<T>(getDatatype()) &&
+        !isSameComplexFloatingPoint<T>(getDatatype()) &&
+        !isSameChar<T>(getDatatype()))
     {
         std::ostringstream oss;
         oss << "Datatypes of patch data (" << dtype << ") and dataset ("

Original file line number	Diff line number	Diff line change
`@@ -160,7 +160,10 @@ template <typename T>`
`160`	`160`	`inline void PatchRecordComponent::store(uint64_t idx, T data)`
`161`	`161`	`{`
`162`	`162`	`Datatype dtype = determineDatatype<T>();`
`163`		`- if (dtype != getDatatype())`
	`163`	`+ if (dtype != getDatatype() && !isSameInteger<T>(getDatatype()) &&`
	`164`	`+ !isSameFloatingPoint<T>(getDatatype()) &&`
	`165`	`+ !isSameComplexFloatingPoint<T>(getDatatype()) &&`
	`166`	`+ !isSameChar<T>(getDatatype()))`
`164`	`167`	`{`
`165`	`168`	`std::ostringstream oss;`
`166`	`169`	`oss << "Datatypes of patch data (" << dtype << ") and dataset ("`
`@@ -187,7 +190,10 @@ template <typename T>`
`187`	`190`	`inline void PatchRecordComponent::store(T data)`
`188`	`191`	`{`
`189`	`192`	`Datatype dtype = determineDatatype<T>();`
`190`		`- if (dtype != getDatatype())`
	`193`	`+ if (dtype != getDatatype() && !isSameInteger<T>(getDatatype()) &&`
	`194`	`+ !isSameFloatingPoint<T>(getDatatype()) &&`
	`195`	`+ !isSameComplexFloatingPoint<T>(getDatatype()) &&`
	`196`	`+ !isSameChar<T>(getDatatype()))`
`191`	`197`	`{`
`192`	`198`	`std::ostringstream oss;`
`193`	`199`	`oss << "Datatypes of patch data (" << dtype << ") and dataset ("`