Skip to content

Commit c099aae

Browse files
committed
Rename ClosureHandler to ClosureInvoker, update related methods, parameters, and tests for consistency.
1 parent c32fb07 commit c099aae

3 files changed

Lines changed: 21 additions & 21 deletions

File tree

src/Decorator/AbstractCallableDecorator.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -11,9 +11,9 @@ abstract class AbstractCallableDecorator implements CallableDecoratorInterface
1111
final public function decorate(\Closure $closure, CallableMetadata $metadata): \Closure
1212
{
1313
return function (mixed ...$args) use ($closure, $metadata): mixed {
14-
return $this->invoke(new ClosureHandler($closure, $args), $metadata);
14+
return $this->invoke(new ClosureInvoker($closure, $args), $metadata);
1515
};
1616
}
1717

18-
abstract protected function invoke(ClosureHandler $handler, CallableMetadata $metadata): mixed;
18+
abstract protected function invoke(ClosureInvoker $invoker, CallableMetadata $metadata): mixed;
1919
}
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
namespace OpenSolid\CallableInvoker\Decorator;
66

7-
final readonly class ClosureHandler
7+
final readonly class ClosureInvoker
88
{
99
/**
1010
* @param array<array-key, mixed> $arguments
@@ -15,7 +15,7 @@ public function __construct(
1515
) {
1616
}
1717

18-
public function handle(): mixed
18+
public function invoke(): mixed
1919
{
2020
return ($this->closure)(...$this->arguments);
2121
}

tests/Unit/Decorator/AbstractCallableDecoratorTest.php

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44

55
use OpenSolid\CallableInvoker\CallableMetadata;
66
use OpenSolid\CallableInvoker\Decorator\AbstractCallableDecorator;
7-
use OpenSolid\CallableInvoker\Decorator\ClosureHandler;
7+
use OpenSolid\CallableInvoker\Decorator\ClosureInvoker;
88
use OpenSolid\CallableInvoker\Tests\Unit\TestHelper;
99
use PHPUnit\Framework\Attributes\Test;
1010
use PHPUnit\Framework\TestCase;
@@ -22,9 +22,9 @@ public function supports(CallableMetadata $metadata): bool
2222
return true;
2323
}
2424

25-
protected function invoke(ClosureHandler $handler, CallableMetadata $metadata): mixed
25+
protected function invoke(ClosureInvoker $invoker, CallableMetadata $metadata): mixed
2626
{
27-
return $handler->handle();
27+
return $invoker->invoke();
2828
}
2929
};
3030

@@ -42,9 +42,9 @@ public function supports(CallableMetadata $metadata): bool
4242
return true;
4343
}
4444

45-
protected function invoke(ClosureHandler $handler, CallableMetadata $metadata): mixed
45+
protected function invoke(ClosureInvoker $invoker, CallableMetadata $metadata): mixed
4646
{
47-
return $handler->handle();
47+
return $invoker->invoke();
4848
}
4949
};
5050

@@ -62,9 +62,9 @@ public function supports(CallableMetadata $metadata): bool
6262
return true;
6363
}
6464

65-
protected function invoke(ClosureHandler $handler, CallableMetadata $metadata): string
65+
protected function invoke(ClosureInvoker $invoker, CallableMetadata $metadata): string
6666
{
67-
return '[wrapped] '.$handler->handle();
67+
return '[wrapped] '.$invoker->invoke();
6868
}
6969
};
7070

@@ -82,7 +82,7 @@ public function supports(CallableMetadata $metadata): bool
8282
return true;
8383
}
8484

85-
protected function invoke(ClosureHandler $handler, CallableMetadata $metadata): string
85+
protected function invoke(ClosureInvoker $invoker, CallableMetadata $metadata): string
8686
{
8787
return 'short-circuited';
8888
}
@@ -96,10 +96,10 @@ protected function invoke(ClosureHandler $handler, CallableMetadata $metadata):
9696
#[Test]
9797
public function decorateExposesClosureAndArgumentsViaHandler(): void
9898
{
99-
$capturedHandler = null;
99+
$capturedInvoker = null;
100100

101-
$decorator = new class($capturedHandler) extends AbstractCallableDecorator {
102-
public function __construct(private(set) ?ClosureHandler &$captured)
101+
$decorator = new class($capturedInvoker) extends AbstractCallableDecorator {
102+
public function __construct(private(set) ?ClosureInvoker &$captured)
103103
{
104104
}
105105

@@ -108,11 +108,11 @@ public function supports(CallableMetadata $metadata): bool
108108
return true;
109109
}
110110

111-
protected function invoke(ClosureHandler $handler, CallableMetadata $metadata): mixed
111+
protected function invoke(ClosureInvoker $invoker, CallableMetadata $metadata): mixed
112112
{
113-
$this->captured = $handler;
113+
$this->captured = $invoker;
114114

115-
return $handler->handle();
115+
return $invoker->invoke();
116116
}
117117
};
118118

@@ -121,8 +121,8 @@ protected function invoke(ClosureHandler $handler, CallableMetadata $metadata):
121121
$result = $decorated(5);
122122

123123
self::assertSame(10, $result);
124-
self::assertNotNull($capturedHandler);
125-
self::assertSame([5], $capturedHandler->arguments);
126-
self::assertSame($result, ($capturedHandler->closure)(5));
124+
self::assertNotNull($capturedInvoker);
125+
self::assertSame([5], $capturedInvoker->arguments);
126+
self::assertSame($result, ($capturedInvoker->closure)(5));
127127
}
128128
}

0 commit comments

Comments
 (0)