chore: followup bug 2021694 - Make other XUL frame attributes regular bool attrs

Author: onemen

@types/general.d.ts

@@ -144,6 +144,7 @@ declare namespace MockedGeckoTypes {
     readonly currentURI: URI;
     droppedLinkHandler: typeof handleDroppedLink;
     getAttribute(name: string): string | null;
+    hasAttribute(name: string): boolean;
     focus(): void;
     // we overrife these see addon.d.ts
     // fixupAndLoadURIString: (uri: string, loadURIOptions?: LoadURIOptions) => void;

@types/modules.d.ts

@@ -1540,6 +1540,7 @@ declare namespace TabmixSvcModule {
     i10IdMap: I10Map;
     isFixedGoogleUrl: (url: string) => boolean;
     isGlitterInstalled?: boolean;
+    isRemoteBrowser: (browser: MockedGeckoTypes.ChromeBrowser) => boolean;
     newtabUrl: string;
     setCustomTabValue: (tab: Tab, key: string, value?: unknown) => void;
     setLabel: (property: string) => string;

addon/chrome/content/click/click.js

@@ -1185,7 +1185,7 @@ var TabmixContext = {
       // for remote tab get call getValidUrl when it is safe to use CPOWs
       // getValidUrl may call getParamsForLink
       if (
-        tab.linkedBrowser.getAttribute("remote") == "true" &&
+        TabmixSvc.isRemoteBrowser(tab.linkedBrowser) &&
         onLink &&
         (Tabmix.prefs.getBoolPref("openLinkHere") ||
           Tabmix.prefs.getBoolPref("openInverseLink") ||

addon/chrome/content/minit/tablib.js

@@ -1411,10 +1411,7 @@ Tabmix.tablib = {
       };
 
       let browser = gBrowser.selectedBrowser;
-      if (
-        browser.getAttribute("remote") == "true" &&
-        typeof gContextMenu.tabmixLinkURL != "undefined"
-      ) {
+      if (TabmixSvc.isRemoteBrowser(browser) && typeof gContextMenu.tabmixLinkURL != "undefined") {
         return gContextMenu.tabmixLinkURL;
       }
 
@@ -1970,7 +1967,7 @@ Tabmix.tablib = {
     }
 
     if (
-      aBrowser.getAttribute("remote") == "true" &&
+      TabmixSvc.isRemoteBrowser(aBrowser) &&
       aTab._restoreState == 2 &&
       this.labels.indexOf(aTab.label) > -1
     ) {

addon/modules/AutoReload.sys.mjs

@@ -353,7 +353,7 @@ function _reloadTab(aTab) {
   }
 
   var browser = aTab.linkedBrowser;
-  if (browser.getAttribute("remote")) {
+  if (TabmixSvc.isRemoteBrowser(browser)) {
     browser.messageManager.sendAsyncMessage("Tabmix:collectReloadData", {});
     return;
   }

addon/modules/ContentClick.sys.mjs

@@ -289,7 +289,7 @@ ContentClickInternal = {
     }
 
     let targetAttr = wrappedNode && wrappedNode.target;
-    if (href && browser.getAttribute("remote") == "true" && where == "default" && targetAttr) {
+    if (href && lazy.TabmixSvc.isRemoteBrowser(browser) && where == "default" && targetAttr) {
       let win = this._window;
       win.setTimeout(() => {
         // don't try to select new tab if the original browser is no longer
@@ -1235,7 +1235,7 @@ ContentClickInternal = {
         }
         if (tab && !tab.hasAttribute("pending")) {
           let browser = tab.linkedBrowser;
-          if (browser.getAttribute("remote") == "true") {
+          if (lazy.TabmixSvc.isRemoteBrowser(browser)) {
             browser.messageManager.sendAsyncMessage("Tabmix:isFrameInContent", this.frameData);
           } else if (this.frameData) {
             let result = lazy.LinkNodeUtils.isFrameInContent(

addon/modules/MergeWindows.sys.mjs

@@ -233,7 +233,7 @@ export const MergeWindows = {
       if (placePopupNextToOpener) {
         let browser = tab.linkedBrowser;
         openerWindowID = browser.browsingContext?.opener?.currentWindowGlobal?.outerWindowId;
-        if (!openerWindowID && browser.getAttribute("remote") == "true") {
+        if (!openerWindowID && TabmixSvc.isRemoteBrowser(browser)) {
           tab.__tabmixTabBrowser = tabbrowser;
           browser.messageManager.sendAsyncMessage("Tabmix:collectOpener", {});
           waitToMessage = true;

addon/modules/TabmixSvc.sys.mjs

@@ -217,6 +217,12 @@ export const TabmixSvc = {
   },
 };
 
+if (lazy.isVersion(1500)) {
+  TabmixSvc.isRemoteBrowser = browser => browser.hasAttribute("remote");
+} else {
+  TabmixSvc.isRemoteBrowser = browser => browser.getAttribute("remote") == "true";
+}
+
 ChromeUtils.defineLazyGetter(TabmixSvc, "prefs", () => {
   const {Preferences} = ChromeUtils.importESModule("resource://gre/modules/Preferences.sys.mjs");
   return new Preferences("");