Qt's sender() function is an older pattern from before Signals and Slots supported lambdas.
Example:
|
void ImporterEntryPathItemDelegate::updateText() |
|
{ |
|
QLineEdit *lineEdit = dynamic_cast<QLineEdit *>(sender()); |
|
QWidget *editor = lineEdit->parentWidget(); |
|
emit commitData(editor); |
|
} |
They're a legacy approach that are extremely brittle due to violating type safety and encapsulation.
Anywhere that we are using sender() should be refactored in some manner.
This does not need to be fixed in a signal PR or commit.
Qt's sender() function is an older pattern from before Signals and Slots supported lambdas.
Example:
obs-studio/frontend/importer/ImporterEntryPathItemDelegate.cpp
Lines 155 to 160 in 5dacbb6
They're a legacy approach that are extremely brittle due to violating type safety and encapsulation.
Anywhere that we are using sender() should be refactored in some manner.
This does not need to be fixed in a signal PR or commit.