Lets remove nameserver2!

[HorvathAkosPeter]

1. As I can see, the code itself never uses it.
2. Here we have nothing to do to the secondary DNSes of the zones. What a domain means for is, is essentially a dyndns connection (address, protocol, key name, secret).

What do you think?

[ThomasWaldmann]

nameserver2 is used for resolving.

Depending on some flag, it either is preferred there to the primary or acts as a fallback.

[HorvathAkosPeter]

1. I have checked the code and I can not see it. Possibly I did not check it enough well. Could you help?

2. Even if it has a function, the name might be misleading. Usually domains have primary and secondary nameservers due to redundancy. Here these would not be secondary nameservers in this sense. In our view, the nameservers of the domains are simply NS records, which might be the same what we manage with dyndns2 queries, or not.

3. What function I can imagine for nameserver2: actually, we are doing multiple things with the zones: we download whole zones (AXFR), we send them update requests (dyndns), and finally we query them for induvidual records. In many constructions, these can not be the same, or it is not optimal if they are the same. For example, in my development environment, I am doing the dyndns updates over a portforwarding, but querying the dns would be much better over udp or DoT, to another ip. This could be done, but I can not see similars in the source.

I think if nameserver2 remains, it should have a name differeent of primary/secondary, because that is misleading, these are not primary/secondary servers as it is usual in the DNS world.

[ThomasWaldmann]

There:

nsupdate.info/src/nsupdate/main/dnstools.py

Line 252 in 35bd02e

resolver.nameservers.insert(pos, nameserver2)

IIRC, the idea was to optionally send QUERIES to nameserver2 first, to put less load onto the primary DNS.

UPDATES are always sent to the primary.