ffi: validate 'void' as parameter type in getFunction and getFunctions

Fixes: #63461
Signed-off-by: Anshikakalpana <anshikajain196872@gmail.com>

Author: Anshikakalpana

lib/internal/ffi-shared-buffer.js

@@ -34,6 +34,7 @@ const {
 const {
   codes: {
     ERR_INTERNAL_ASSERTION,
+    ERR_INVALID_ARG_VALUE,
   },
 } = require('internal/errors');
 
@@ -555,6 +556,18 @@ function sigResult(sig) {
   return sig.result ?? sig.return ?? sig.returns ?? 'void';
 }
 
+function validateParameters(parameters, prefix) {
+  for (let i = 0; i < parameters.length; i++) {
+    if (parameters[i] === 'void') {
+      throw new ERR_INVALID_ARG_VALUE(
+        `${prefix}[${i}]`,
+        parameters[i],
+        'must not be "void"; use an empty array for no-argument functions',
+      );
+    }
+  }
+}
+
 // The native invoker for SB-eligible symbols is `InvokeFunctionSB`, which
 // reads arguments from the shared buffer populated by
 // `wrapWithSharedBuffer`. These patches make sure every path that surfaces
@@ -566,8 +579,10 @@ const rawGetFunctions = DynamicLibrary.prototype.getFunctions;
 DynamicLibrary.prototype.getFunction = function getFunction(name, sig) {
   // Native `DynamicLibrary::GetFunction` validates `sig`, so by the time
   // we have `raw` we know `sig` is a valid object.
+  const params = sigParams(sig);
+  validateParameters(params, 'options.parameters');
   const raw = FunctionPrototypeCall(rawGetFunction, this, name, sig);
-  return wrapWithSharedBuffer(raw, sigParams(sig), sigResult(sig));
+  return wrapWithSharedBuffer(raw, params, sigResult(sig));
 };
 
 DynamicLibrary.prototype.getFunctions = function getFunctions(definitions) {
@@ -589,7 +604,9 @@ DynamicLibrary.prototype.getFunctions = function getFunctions(definitions) {
       out[name] = wrapWithSharedBuffer(raw[name]);
     } else {
       const sig = definitions[name];
-      out[name] = wrapWithSharedBuffer(raw[name], sigParams(sig), sigResult(sig));
+      const params = sigParams(sig);
+      validateParameters(params, `definitions.${name}.parameters`);
+      out[name] = wrapWithSharedBuffer(raw[name], params, sigResult(sig));
     }
   }
   return out;

test/parallel/test-ffi-void-parameter.js

@@ -0,0 +1,32 @@
+'use strict';
+
+const common = require('../common');
+
+if (!process.config.variables.node_use_ffi) {
+  common.skip('requires FFI support');
+}
+
+const assert = require('node:assert');
+const { spawnSync } = require('node:child_process');
+
+// Regression test for https://github.com/nodejs/node/issues/63461
+// 'void' as a parameter type should throw ERR_INVALID_ARG_VALUE
+// instead of triggering ERR_INTERNAL_ASSERTION.
+
+{
+  const { stderr, status } = spawnSync(process.execPath, [
+    '--expose-internals',
+    '-e',
+    `
+      const { DynamicLibrary } = internalBinding('ffi');
+      const lib = new DynamicLibrary(null);
+      lib.getFunction('f', { parameters: ['void'] });
+    `,
+  ], {
+    encoding: 'utf8',
+  });
+
+  assert.strictEqual(status, 1);
+  assert.match(stderr, /ERR_INVALID_ARG_VALUE/);
+  assert.doesNotMatch(stderr, /ERR_INTERNAL_ASSERTION/);
+}