Skip to content

Recommend persistent block device naming over bus-based naming when using disko-install with the --disk option #1233

Description

@dimitarkolevdtd

The example in the disko-install documentation suggests specifying a device like /dev/disk/by-id/some-disk-id in configuration.nix, but then proceeds to show overwriting the value with /dev/sda. This might lead some readers to believe this is safe to do. However, the order in which devices with bus-based naming schemes are discovered is arbitrary and can change across reboots.

The documentation should explicitly advise against specifying disks in this way.

Alternatively, the disko-install CLI could include an option to "expand" a short name like /dev/sda into its corresponding persistent disk ID at runtime, which would be a nice convenience feature. However, this shouldn't be the default behavior, as some users might be relying on the current functionality.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions