Skip to content

Comments

Enhancement/folder icon changed to be closer to the title "View in Folder".#58436

Merged
nickvergessen merged 1 commit intonextcloud:masterfrom
redsteadz:enhancement/folder-icon
Feb 24, 2026
Merged

Enhancement/folder icon changed to be closer to the title "View in Folder".#58436
nickvergessen merged 1 commit intonextcloud:masterfrom
redsteadz:enhancement/folder-icon

Conversation

@redsteadz
Copy link
Contributor

@redsteadz redsteadz commented Feb 19, 2026

  • Resolves: #

Summary

Changed the Icon to be more descriptive of the functionality and different from the Move or copy button.
Ref: #57276

TODO

  • [ x] Change the position of View to be closer to View in Folder

Checklist

image image
  • [ x] Documentation (manuals or wiki) has been updated or is not required
    • Not required.
  • [x ] Backports requested where applicable (ex: critical bugfixes)
  • Labels added where applicable (ex: bug/enhancement, 3. to review, feature component)
  • Milestone added for target branch/version (ex: 32.x for stable32)

@redsteadz redsteadz requested review from a team and skjnldsv as code owners February 19, 2026 14:01
@redsteadz redsteadz requested review from nfebe and szaimen and removed request for a team February 19, 2026 14:01
Copy link
Contributor

@szaimen szaimen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! :)

@szaimen szaimen added 3. to review Waiting for reviews design Design, UI, UX, etc. labels Feb 19, 2026
@szaimen szaimen added this to the Nextcloud 34 milestone Feb 19, 2026
@redsteadz redsteadz force-pushed the enhancement/folder-icon branch from 8a63a51 to 5a6dcc1 Compare February 24, 2026 18:15
@redsteadz redsteadz requested review from CarlSchwan, leftybournes and salmart-dev and removed request for a team February 24, 2026 18:15
@redsteadz
Copy link
Contributor Author

AHH Why am i so bad at a simple simple merge pull reqq

@miaulalala
Copy link
Contributor

miaulalala commented Feb 24, 2026

AHH Why am i so bad at a simple simple merge pull reqq

Do:

git reset --soft origin/master
git restore --staged .
and then use
git add -p to commit only the relevant changes

@redsteadz
Copy link
Contributor Author

Thank you,,
I think I fixed the merge issues? But I will apply it like this if required
Is the issue due to DCO? some of my commits were not signed as I was not aware of this being the case.

@miaulalala
Copy link
Contributor

Quite a few merge lines left - if you need some help, join us at https://cloud.nextcloud.com/call/xs25tz5y

@redsteadz
Copy link
Contributor Author

Oh, what a sad blunder. Yes would love the help, thank you

@redsteadz redsteadz force-pushed the enhancement/folder-icon branch from 8baa3e0 to d904f79 Compare February 24, 2026 19:33
@redsteadz redsteadz force-pushed the enhancement/folder-icon branch 2 times, most recently from d90a154 to 1970af1 Compare February 24, 2026 20:00
@redsteadz redsteadz force-pushed the enhancement/folder-icon branch from 1970af1 to 9b7feee Compare February 24, 2026 20:22
@nickvergessen nickvergessen merged commit 1cb826e into nextcloud:master Feb 24, 2026
113 of 116 checks passed
@welcome
Copy link

welcome bot commented Feb 24, 2026

Thanks for your first pull request and welcome to the community! Feel free to keep them coming! If you are looking for issues to tackle then have a look at this selection: https://github.com/nextcloud/server/issues?q=is%3Aopen+is%3Aissue+label%3A%22good+first+issue%22

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3. to review Waiting for reviews design Design, UI, UX, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants