Merge pull request #58553 from nextcloud/backport/58543/stable33

[stable33] fix: correctly return false for filesize on non-existing file

Author: susnux

lib/private/Files/Storage/Common.php

@@ -92,11 +92,15 @@ public function is_file(string $path): bool {
 	}
 
 	public function filesize(string $path): int|float|false {
-		if ($this->is_dir($path)) {
-			return 0; //by definition
+		$type = $this->filetype($path);
+		if ($type === false) {
+			return false;
+		}
+		if ($type !== 'file') {
+			return 0;
 		} else {
 			$stat = $this->stat($path);
-			return isset($stat['size']) ? $stat['size'] : 0;
+			return $stat['size'] ?? 0;
 		}
 	}
 

lib/private/Files/Storage/Local.php

@@ -215,15 +215,19 @@ public function getMetaData(string $path): ?array {
 	}
 
 	public function filetype(string $path): string|false {
-		$filetype = filetype($this->getSourcePath($path));
+		$filetype = @filetype($this->getSourcePath($path));
 		if ($filetype == 'link') {
 			$filetype = filetype(realpath($this->getSourcePath($path)));
 		}
 		return $filetype;
 	}
 
 	public function filesize(string $path): int|float|false {
-		if (!$this->is_file($path)) {
+		$type = $this->filetype($path);
+		if ($type === false) {
+			return false;
+		}
+		if ($type !== 'file') {
 			return 0;
 		}
 		$fullPath = $this->getSourcePath($path);

tests/lib/Files/Storage/Storage.php

@@ -311,6 +311,8 @@ public function testStat(): void {
 
 		$this->instance->unlink('/lorem.txt');
 		$this->assertTrue($this->instance->hasUpdated('/', $mtimeStart - 5));
+
+		$this->assertFalse($this->instance->filesize('/non-existing-file.txt'));
 	}
 
 	/**