Test that move or copy files starts in the file's parent folder#16262
Merged
alperozturk96 merged 2 commits intomasterfrom Jan 15, 2026
Merged
Test that move or copy files starts in the file's parent folder#16262alperozturk96 merged 2 commits intomasterfrom
alperozturk96 merged 2 commits intomasterfrom
Conversation
1 task
alperozturk96
requested changes
Jan 13, 2026
| activity.supportFragmentManager.executePendingTransactions() | ||
|
|
||
| fragment.listDirectory(testFolder, false) | ||
| activity.supportFragmentManager.executePendingTransactions() |
Collaborator
There was a problem hiding this comment.
The first activity.supportFragmentManager.executePendingTransactions() is needed after adding fragment other two is not needed because we are not showing another fragment via listDirectory or onFileActionChosen(R.id.action_move_or_copy, setOf(testFile))
When I tested with only first one it worked as well.
This tests the changes of #15925, where the old behavior of moving up to the root folder was changed to stay in the parent folder of the file(s) to move/copy. The new behavior is in sync with iOS and the Web UI, hence this test ensures it doesn't break Signed-off-by: Philipp Hasper <vcs@hasper.info>
PhilLab
force-pushed
the
test_15925_move_or_copy_start_in_parent
branch
from
9445d8c to
54e9c43
Compare
Signed-off-by: Philipp Hasper <vcs@hasper.info>
|
APK file: https://www.kaminsky.me/nc-dev/android-artifacts/16262.apk |
|
blue-Light-Screenshot test failed, but no output was generated. Maybe a preliminary stage failed. |
alperozturk96
approved these changes
Jan 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Original PR: #16188
This tests the changes of #15925, where the old behavior of moving up to the root folder was changed to stay in the parent folder of the file(s) to move/copy.
The new behavior is in sync with iOS and the Web UI, hence this test ensures it doesn't break