Cleanup of IOException leftovers after update to jackson3 (#1244)

afiluba · afiluba · web-flow · commit 331ced5cd8e4 · 2026-04-20T08:09:24.000-04:00
* fix: adapt to jackson3 exception (JacksonException vs IOException)

* fix: let the JacksonException be thrown

* test: add invalid json schema test

---------

Co-authored-by: afiluba &lt;afiluba@gmail.com&gt;
diff --git a/src/main/java/com/networknt/schema/Schema.java b/src/main/java/com/networknt/schema/Schema.java
@@ -1188,11 +1188,7 @@ public <T> T validate(ExecutionContext executionContext, JsonNode node, OutputFo
      * @return the JsonNode.
      */
     private JsonNode deserialize(String input, InputFormat inputFormat) {
-        try {
-            return this.getSchemaContext().getSchemaRegistry().readTree(input, inputFormat);
-        } catch (IOException e) {
-            throw new UncheckedIOException("Invalid input", e);
-        }
+        return this.getSchemaContext().getSchemaRegistry().readTree(input, inputFormat);
     }
 
     /**
diff --git a/src/main/java/com/networknt/schema/SchemaRegistry.java b/src/main/java/com/networknt/schema/SchemaRegistry.java
@@ -584,11 +584,11 @@ public Dialect getDialect(String dialectId) {
         return dialectRegistry.getDialect(key, this);
     }
 
-    JsonNode readTree(String content, InputFormat inputFormat) throws IOException {
+    JsonNode readTree(String content, InputFormat inputFormat) {
         return this.nodeReader.readTree(content, inputFormat);
     }
 
-    JsonNode readTree(InputStream content, InputFormat inputFormat) throws IOException {
+    JsonNode readTree(InputStream content, InputFormat inputFormat) {
         return this.nodeReader.readTree(content, inputFormat);
     }
 
@@ -616,13 +616,8 @@ public Schema getSchema(final String schema) {
      * @return the schema
      */
     public Schema getSchema(final String schema, InputFormat inputFormat) {
-        try {
-            final JsonNode schemaNode = readTree(schema, inputFormat);
-            return newSchema(null, schemaNode);
-        } catch (IOException ioe) {
-            logger.error("Failed to load json schema!", ioe);
-            throw new SchemaException(ioe);
-        }
+        final JsonNode schemaNode = readTree(schema, inputFormat);
+        return newSchema(null, schemaNode);
     }
 
     /**
@@ -649,13 +644,8 @@ public Schema getSchema(final InputStream schemaStream) {
      * @return the schema
      */
     public Schema getSchema(final InputStream schemaStream, InputFormat inputFormat) {
-        try {
-            final JsonNode schemaNode = readTree(schemaStream, inputFormat);
-            return newSchema(null, schemaNode);
-        } catch (IOException ioe) {
-            logger.error("Failed to load json schema!", ioe);
-            throw new SchemaException(ioe);
-        }
+        final JsonNode schemaNode = readTree(schemaStream, inputFormat);
+        return newSchema(null, schemaNode);
     }
 
     /**
@@ -691,13 +681,8 @@ public Schema getSchema(final SchemaLocation schemaUri, final JsonNode jsonNode)
      * @return the schema
      */
     public Schema getSchema(final SchemaLocation schemaUri, final String schema, InputFormat inputFormat) {
-        try {
-            final JsonNode schemaNode = readTree(schema, inputFormat);
-            return newSchema(schemaUri, schemaNode);
-        } catch (IOException ioe) {
-            logger.error("Failed to load json schema!", ioe);
-            throw new SchemaException(ioe);
-        }
+        final JsonNode schemaNode = readTree(schema, inputFormat);
+        return newSchema(schemaUri, schemaNode);
     }
 
     /**
@@ -709,13 +694,8 @@ public Schema getSchema(final SchemaLocation schemaUri, final String schema, Inp
      * @return the schema
      */
     public Schema getSchema(final SchemaLocation schemaUri, final InputStream schemaStream, InputFormat inputFormat) {
-        try {
-            final JsonNode schemaNode = readTree(schemaStream, inputFormat);
-            return newSchema(schemaUri, schemaNode);
-        } catch (IOException ioe) {
-            logger.error("Failed to load json schema!", ioe);
-            throw new SchemaException(ioe);
-        }
+        final JsonNode schemaNode = readTree(schemaStream, inputFormat);
+        return newSchema(schemaUri, schemaNode);
     }
 
     /**
diff --git a/src/main/java/com/networknt/schema/serialization/BasicNodeReader.java b/src/main/java/com/networknt/schema/serialization/BasicNodeReader.java
@@ -16,12 +16,11 @@
 
 package com.networknt.schema.serialization;
 
-import java.io.IOException;
-import java.io.InputStream;
-
+import com.networknt.schema.InputFormat;
 import tools.jackson.databind.JsonNode;
 import tools.jackson.databind.ObjectMapper;
-import com.networknt.schema.InputFormat;
+
+import java.io.InputStream;
 
 /**
  * Basic implementation of {@link NodeReader}.
@@ -39,12 +38,12 @@ protected BasicNodeReader() {
     }
 
     @Override
-    public JsonNode readTree(String content, InputFormat inputFormat) throws IOException {
+    public JsonNode readTree(String content, InputFormat inputFormat) {
         return getObjectMapper(inputFormat).readTree(content);
     }
 
     @Override
-    public JsonNode readTree(InputStream content, InputFormat inputFormat) throws IOException {
+    public JsonNode readTree(InputStream content, InputFormat inputFormat) {
         return getObjectMapper(inputFormat).readTree(content);
     }
 
diff --git a/src/main/java/com/networknt/schema/serialization/DefaultNodeReader.java b/src/main/java/com/networknt/schema/serialization/DefaultNodeReader.java
@@ -1,6 +1,5 @@
 package com.networknt.schema.serialization;
 
-import java.io.IOException;
 import java.io.InputStream;
 
 import tools.jackson.databind.JsonNode;
@@ -33,7 +32,7 @@ protected DefaultNodeReader(ObjectMapper jsonMapper, ObjectMapper yamlMapper,
     }
 
     @Override
-    public JsonNode readTree(String content, InputFormat inputFormat) throws IOException {
+    public JsonNode readTree(String content, InputFormat inputFormat) {
         if (this.jsonNodeFactoryFactory == null) {
             return getObjectMapper(inputFormat).readTree(content);
         } else {
@@ -42,7 +41,7 @@ public JsonNode readTree(String content, InputFormat inputFormat) throws IOExcep
     }
 
     @Override
-    public JsonNode readTree(InputStream content, InputFormat inputFormat) throws IOException {
+    public JsonNode readTree(InputStream content, InputFormat inputFormat) {
         if (this.jsonNodeFactoryFactory == null) {
             return getObjectMapper(inputFormat).readTree(content);
         } else {
diff --git a/src/main/java/com/networknt/schema/serialization/NodeReader.java b/src/main/java/com/networknt/schema/serialization/NodeReader.java
@@ -15,7 +15,6 @@
  */
 package com.networknt.schema.serialization;
 
-import java.io.IOException;
 import java.io.InputStream;
 
 import tools.jackson.databind.JsonNode;
@@ -32,19 +31,17 @@ public interface NodeReader {
      * @param content     the content
      * @param inputFormat the input format
      * @return the node
-     * @throws IOException IOException
      */
-    JsonNode readTree(String content, InputFormat inputFormat) throws IOException;
+    JsonNode readTree(String content, InputFormat inputFormat);
 
     /**
      * Deserialize content as a tree.
      * 
      * @param content input stream
      * @param inputFormat input format
      * @return the node
-     * @throws IOException IOException
      */
-    JsonNode readTree(InputStream content, InputFormat inputFormat) throws IOException;
+    JsonNode readTree(InputStream content, InputFormat inputFormat);
 
     /**
      * Creates a builder for {@link NodeReader}.
diff --git a/src/main/java/com/networknt/schema/utils/JsonNodes.java b/src/main/java/com/networknt/schema/utils/JsonNodes.java
@@ -17,7 +17,6 @@
 
 import java.io.InputStream;
 
-import tools.jackson.core.JacksonException;
 import tools.jackson.core.TokenStreamLocation;
 import tools.jackson.core.JsonParser;
 import tools.jackson.databind.JsonNode;
@@ -89,8 +88,6 @@ public static JsonNode readTree(ObjectMapper objectMapper, String content,
             ObjectReader reader = objectMapper.reader(nodeFactory);
             JsonNode result = reader.readTree(parser);
             return (result != null) ? result : nodeFactory.missingNode();
-        } catch (JacksonException e) {
-            throw new IllegalArgumentException("Invalid input", e);
         }
     }
 
@@ -109,8 +106,6 @@ public static JsonNode readTree(ObjectMapper objectMapper, InputStream inputStre
             ObjectReader reader = objectMapper.reader(nodeFactory);
             JsonNode result = reader.readTree(parser);
             return (result != null) ? result : nodeFactory.missingNode();
-        } catch (JacksonException e) {
-            throw new IllegalArgumentException("Invalid input", e);
         }
     }
 
diff --git a/src/test/java/com/networknt/schema/SchemaRegistryTest.java b/src/test/java/com/networknt/schema/SchemaRegistryTest.java
@@ -30,6 +30,7 @@
 import com.networknt.schema.dialect.BasicDialectRegistry;
 import com.networknt.schema.dialect.Dialect;
 import com.networknt.schema.dialect.Dialects;
+import tools.jackson.core.JacksonException;
 
 /**
  * Tests for JsonSchemaFactory.
@@ -159,4 +160,12 @@ void noDialectReferredByParentShouldDefaultToDefaultDialect() {
         Schema nested = registry.getSchema(SchemaLocation.of("https://example.org/schema"));
         assertEquals(Dialects.getDraft4(), nested.getSchemaContext().getDialect());
     }
+
+    @Test
+    void invalidJsonSchema() {
+        SchemaRegistry registry = SchemaRegistry.builder().build();
+        assertThrows(JacksonException.class, () -> {
+            registry.getSchema("INVALID_JSON");
+        });
+    }
 }
diff --git a/src/test/java/com/networknt/schema/serialization/DefaultNodeReaderTest.java b/src/test/java/com/networknt/schema/serialization/DefaultNodeReaderTest.java
@@ -16,7 +16,6 @@
 package com.networknt.schema.serialization;
 
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import java.io.IOException;
 
 import org.junit.jupiter.api.Test;
 
@@ -30,7 +29,7 @@
  */
 class DefaultNodeReaderTest {
     @Test
-    void location() throws IOException {
+    void location() {
         String schemaData = "{\r\n"
                 + "  \"$id\": \"https://schema/myschema\",\r\n"
                 + "  \"properties\": {\r\n"
@@ -58,7 +57,7 @@ void location() throws IOException {
     }
 
     @Test
-    void jsonLocation() throws IOException {
+    void jsonLocation() {
         String schemaData = "{\r\n"
                 + "  \"$id\": \"https://schema/myschema\",\r\n"
                 + "  \"properties\": {\r\n"
@@ -81,7 +80,7 @@ void jsonLocation() throws IOException {
     }
 
     @Test
-    void yamlLocation() throws IOException {
+    void yamlLocation() {
         String schemaData = "---\r\n"
                 + "\"$id\": 'https://schema/myschema'\r\n"
                 + "properties:\r\n"

Original file line number	Diff line number	Diff line change
`@@ -17,7 +17,6 @@`
`17`	`17`
`18`	`18`	`import java.io.InputStream;`
`19`	`19`
`20`		`-import tools.jackson.core.JacksonException;`
`21`	`20`	`import tools.jackson.core.TokenStreamLocation;`
`22`	`21`	`import tools.jackson.core.JsonParser;`
`23`	`22`	`import tools.jackson.databind.JsonNode;`
`@@ -89,8 +88,6 @@ public static JsonNode readTree(ObjectMapper objectMapper, String content,`
`89`	`88`	`ObjectReader reader = objectMapper.reader(nodeFactory);`
`90`	`89`	`JsonNode result = reader.readTree(parser);`
`91`	`90`	`return (result != null) ? result : nodeFactory.missingNode();`
`92`		`- } catch (JacksonException e) {`
`93`		`- throw new IllegalArgumentException("Invalid input", e);`
`94`	`91`	`}`
`95`	`92`	`}`
`96`	`93`
`@@ -109,8 +106,6 @@ public static JsonNode readTree(ObjectMapper objectMapper, InputStream inputStre`
`109`	`106`	`ObjectReader reader = objectMapper.reader(nodeFactory);`
`110`	`107`	`JsonNode result = reader.readTree(parser);`
`111`	`108`	`return (result != null) ? result : nodeFactory.missingNode();`
`112`		`- } catch (JacksonException e) {`
`113`		`- throw new IllegalArgumentException("Invalid input", e);`
`114`	`109`	`}`
`115`	`110`	`}`
`116`	`111`