Skip to content

Commit e4c6e3b

Browse files
committed
used setFactory() instead of misused setClass()
1 parent b62d2f5 commit e4c6e3b

File tree

5 files changed

+13
-13
lines changed

5 files changed

+13
-13
lines changed

src/Bridges/ApplicationDI/ApplicationExtension.php

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,7 @@ public function loadConfiguration()
6363
: UI\Presenter::INVALID_LINK_WARNING;
6464

6565
$application = $builder->addDefinition($this->prefix('application'))
66-
->setClass(Nette\Application\Application::class)
66+
->setFactory(Nette\Application\Application::class)
6767
->addSetup('$catchExceptions', [$config['catchExceptions']])
6868
->addSetup('$errorPresenter', [$config['errorPresenter']]);
6969

@@ -106,7 +106,7 @@ public function beforeCompile()
106106
$counter = 0;
107107
foreach ($this->findPresenters() as $class) {
108108
if (empty($all[$class])) {
109-
$all[$class] = $builder->addDefinition($this->prefix((string) ++$counter))->setClass($class);
109+
$all[$class] = $builder->addDefinition($this->prefix((string) ++$counter))->setFactory($class);
110110
}
111111
}
112112

src/Bridges/ApplicationDI/LatteExtension.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -49,7 +49,7 @@ public function loadConfiguration()
4949
$builder = $this->getContainerBuilder();
5050

5151
$latteFactory = $builder->addDefinition($this->prefix('latteFactory'))
52-
->setClass(Latte\Engine::class)
52+
->setFactory(Latte\Engine::class)
5353
->addSetup('setTempDirectory', [$this->tempDir])
5454
->addSetup('setAutoRefresh', [$this->debugMode])
5555
->addSetup('setContentType', [$config['xhtml'] ? Latte\Compiler::CONTENT_XHTML : Latte\Compiler::CONTENT_HTML])

tests/Bridges.DI/ApplicationExtension.basic.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,9 @@ test(function () {
1919
$compiler->addExtension('application', new ApplicationExtension(false));
2020

2121
$builder = $compiler->getContainerBuilder();
22-
$builder->addDefinition('myRouter')->setClass(Nette\Application\Routers\SimpleRouter::class);
22+
$builder->addDefinition('myRouter')->setFactory(Nette\Application\Routers\SimpleRouter::class);
2323
$builder->addDefinition('myHttpRequest')->setFactory(Nette\Http\Request::class, [new DI\Statement(Nette\Http\UrlScript::class)]);
24-
$builder->addDefinition('myHttpResponse')->setClass(Nette\Http\Response::class);
24+
$builder->addDefinition('myHttpResponse')->setFactory(Nette\Http\Response::class);
2525

2626
$code = $compiler->setClassName('Container1')->compile();
2727
eval($code);

tests/Bridges.DI/ApplicationExtension.invalidLink.phpt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,9 @@ function createCompiler($config)
2121
$compiler = new DI\Compiler;
2222
$compiler->loadConfig(Tester\FileMock::create($config, 'neon'));
2323
$builder = $compiler->getContainerBuilder();
24-
$builder->addDefinition('myRouter')->setClass(Nette\Application\Routers\SimpleRouter::class);
24+
$builder->addDefinition('myRouter')->setFactory(Nette\Application\Routers\SimpleRouter::class);
2525
$builder->addDefinition('myHttpRequest')->setFactory(Nette\Http\Request::class, [new DI\Statement(Nette\Http\UrlScript::class)]);
26-
$builder->addDefinition('myHttpResponse')->setClass(Nette\Http\Response::class);
26+
$builder->addDefinition('myHttpResponse')->setFactory(Nette\Http\Response::class);
2727
return $compiler;
2828
}
2929

tests/Bridges.DI/ApplicationExtension.scan.phpt

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,9 +20,9 @@ test(function () {
2020
$compiler->addExtension('application', new ApplicationExtension);
2121

2222
$builder = $compiler->getContainerBuilder();
23-
$builder->addDefinition('myRouter')->setClass(Nette\Application\Routers\SimpleRouter::class);
23+
$builder->addDefinition('myRouter')->setFactory(Nette\Application\Routers\SimpleRouter::class);
2424
$builder->addDefinition('myHttpRequest')->setFactory(Nette\Http\Request::class, [new DI\Statement(Nette\Http\UrlScript::class)]);
25-
$builder->addDefinition('myHttpResponse')->setClass(Nette\Http\Response::class);
25+
$builder->addDefinition('myHttpResponse')->setFactory(Nette\Http\Response::class);
2626
$code = $compiler->setClassName('Container1')->compile();
2727
eval($code);
2828

@@ -39,9 +39,9 @@ test(function () {
3939
$compiler->addExtension('application', new ApplicationExtension);
4040

4141
$builder = $compiler->getContainerBuilder();
42-
$builder->addDefinition('myRouter')->setClass(Nette\Application\Routers\SimpleRouter::class);
42+
$builder->addDefinition('myRouter')->setFactory(Nette\Application\Routers\SimpleRouter::class);
4343
$builder->addDefinition('myHttpRequest')->setFactory(Nette\Http\Request::class, [new DI\Statement(Nette\Http\UrlScript::class)]);
44-
$builder->addDefinition('myHttpResponse')->setClass(Nette\Http\Response::class);
44+
$builder->addDefinition('myHttpResponse')->setFactory(Nette\Http\Response::class);
4545
$code = $compiler->addConfig([
4646
'application' => [
4747
'scanDirs' => [__DIR__ . '/files'],
@@ -62,9 +62,9 @@ test(function () {
6262
$compiler->addExtension('application', new ApplicationExtension(false, [__DIR__ . '/files']));
6363

6464
$builder = $compiler->getContainerBuilder();
65-
$builder->addDefinition('myRouter')->setClass(Nette\Application\Routers\SimpleRouter::class);
65+
$builder->addDefinition('myRouter')->setFactory(Nette\Application\Routers\SimpleRouter::class);
6666
$builder->addDefinition('myHttpRequest')->setFactory(Nette\Http\Request::class, [new DI\Statement(Nette\Http\UrlScript::class)]);
67-
$builder->addDefinition('myHttpResponse')->setClass(Nette\Http\Response::class);
67+
$builder->addDefinition('myHttpResponse')->setFactory(Nette\Http\Response::class);
6868
$loader = new DI\Config\Loader;
6969
$config = $loader->load(Tester\FileMock::create('
7070
services:

0 commit comments

Comments
 (0)