Fix implicitly marking parameters as nullable (#178)

Justinas-Jurciukonis · Justinas Jurčiukonis · web-flow · commit c3cfa07aa3ee · 2024-12-04T09:11:03.000-06:00
Co-authored-by: Justinas Jurčiukonis &lt;justinas.jurciukoni@twoday.com&gt;
diff --git a/src/NetSuiteClient.php b/src/NetSuiteClient.php
@@ -174,7 +174,7 @@ public function validateConfig(array $config)
      */
     public static function createFromEnv(
         array $options = [],
-        \SoapClient $client = null
+        ?\SoapClient $client = null
     ) {
         $config = self::getEnvConfig();
 
diff --git a/src/includes/functions.php b/src/includes/functions.php
@@ -33,7 +33,7 @@ function array_is_associative($array)
 
 namespace {
 
-    function setFields($object, array $fieldArray=null)
+    function setFields($object, ?array $fieldArray=null): void
     {
         // helper method that allows creating objects and setting their properties based on an associative array passed as argument. Mimics functionality from PHP toolkit
         $classname = get_class($object);

Original file line number	Diff line number	Diff line change
`@@ -33,7 +33,7 @@ function array_is_associative($array)`
`33`	`33`
`34`	`34`	`namespace {`
`35`	`35`
`36`		`- function setFields($object, array $fieldArray=null)`
	`36`	`+ function setFields($object, ?array $fieldArray=null): void`
`37`	`37`	`{`
`38`	`38`	`// helper method that allows creating objects and setting their properties based on an associative array passed as argument. Mimics functionality from PHP toolkit`
`39`	`39`	`$classname = get_class($object);`