Skip to content

Commit d5bd760

Browse files
author
harry-tzien
committed
fix: pyporject.toml typo in torch version, undistort_view now passes metadata to new camera instance, paralleldatamanager now uses iter_eval_raybundles instead of iter_train_bundles, add a version specification in dockerfile to pass github tests
1 parent 50e0e3c commit d5bd760

File tree

4 files changed

+4
-3
lines changed

4 files changed

+4
-3
lines changed

Dockerfile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ RUN git clone https://github.com/colmap/colmap.git && \
8181

8282
# Upgrade pip and install dependencies.
8383
# pip install torch==2.2.2 torchvision==0.17.2 --index-url https://download.pytorch.org/whl/cu118 && \
84-
RUN pip install --no-cache-dir --upgrade pip 'setuptools<70.0.0' && \
84+
RUN pip install --no-cache-dir --upgrade pip==25.2 'setuptools<70.0.0' && \
8585
pip install --no-cache-dir torch==2.1.2+cu118 torchvision==0.16.2+cu118 'numpy<2.0.0' --extra-index-url https://download.pytorch.org/whl/cu118 && \
8686
git clone --branch master --recursive https://github.com/cvg/Hierarchical-Localization.git /opt/hloc && \
8787
cd /opt/hloc && git checkout v1.4 && python3.10 -m pip install --no-cache-dir . && cd ~ && \

nerfstudio/data/datamanagers/parallel_datamanager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -248,7 +248,7 @@ def next_train(self, step: int) -> Tuple[RayBundle, Dict]:
248248
def next_eval(self, step: int) -> Tuple[RayBundle, Dict]:
249249
"""Returns the next batch of data from the eval dataloader."""
250250
self.eval_count += 1
251-
ray_bundle, batch = next(self.iter_train_raybundles)[0]
251+
ray_bundle, batch = next(self.iter_eval_raybundles)[0]
252252
ray_bundle = ray_bundle.to(self.device)
253253
batch = get_dict_to_torch(batch, self.device)
254254
return ray_bundle, batch

nerfstudio/data/utils/dataloaders.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -281,6 +281,7 @@ def undistort_view(
281281
cy=torch.Tensor([[float(K[1, 2])]]),
282282
width=torch.Tensor([[image.shape[1]]]).to(torch.int32),
283283
height=torch.Tensor([[image.shape[0]]]).to(torch.int32),
284+
metadata=camera.metadata,
284285
)
285286
return new_camera, data
286287

pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -103,7 +103,7 @@ dev = [
103103
# NOTE: Disabling projectaria-tools because it doesn't have prebuilt windows wheels
104104
# Syntax comes from here: https://pip.pypa.io/en/stable/reference/requirement-specifiers/
105105
"projectaria-tools>=1.3.1; sys_platform != 'win32'",
106-
"torch==2.7.1",
106+
"torch>=2.1.2",
107107
"awscli==1.33.18"
108108
]
109109

0 commit comments

Comments
 (0)