fix(Oracle): keep per-request filter errors from poisoning later ids (#1104)

ProcessRequestAsync mutated the shared URL response code when JSONPath Filter threw. Later requests for the same URL then inherited Error even if their filters would succeed.

Co-authored-by: Shargon <shargon@gmail.com>
Co-authored-by: Alvaro <amjarag@gmail.com>

Author: 3 people

plugins/OracleService/OracleService.cs

@@ -333,19 +333,20 @@ private async Task ProcessRequestAsync(DataCache snapshot, OracleRequest req, Ca
         foreach (var (requestId, request) in NativeContract.Oracle.GetRequestsByUrl(snapshot, req.Url))
         {
             var result = Array.Empty<byte>();
-            if (code == OracleResponseCode.Success)
+            var responseCode = code;
+            if (responseCode == OracleResponseCode.Success)
             {
                 try
                 {
                     result = Filter(data, request.Filter);
                 }
                 catch (Exception ex)
                 {
-                    code = OracleResponseCode.Error;
+                    responseCode = OracleResponseCode.Error;
                     PluginLogger?.Warning("Filter '{Filter}' error: {ErrorMessage}", request.Filter, ex.Message);
                 }
             }
-            var response = new OracleResponse() { Id = requestId, Code = code, Result = result };
+            var response = new OracleResponse() { Id = requestId, Code = responseCode, Result = result };
             var responseTx = CreateResponseTx(snapshot, request, response, oracleNodes, _system.Settings);
             var backupTx = CreateResponseTx(snapshot, request, new OracleResponse()
             {
@@ -355,7 +356,7 @@ private async Task ProcessRequestAsync(DataCache snapshot, OracleRequest req, Ca
             }, oracleNodes, _system.Settings, true);
 
             PluginLogger?.Information("Built response tx: {OriginalTxid}-({RequestId}) {ResponseTxHash}, responseCode:{ResponseCode}, result:{Result}, validUntilBlock:{ValidUntilBlock}, backupTx:{BackupTxHash}-{BackupValidUntilBlock}",
-                req.OriginalTxid, requestId, responseTx.Hash, code, result.ToHexString(), responseTx.ValidUntilBlock, backupTx.Hash, backupTx.ValidUntilBlock);
+                req.OriginalTxid, requestId, responseTx.Hash, responseCode, result.ToHexString(), responseTx.ValidUntilBlock, backupTx.Hash, backupTx.ValidUntilBlock);
 
             var tasks = new List<Task>();
             ECPoint[] oraclePublicKeys = NativeContract.RoleManagement.GetDesignatedByRole(snapshot, Role.Oracle, height);