Skip to content

Commit 254cd81

Browse files
albertvillanovanenuadrian
authored andcommitted
Move VLLMClient to generation module (huggingface#4928)
1 parent 9174233 commit 254cd81

5 files changed

Lines changed: 6 additions & 6 deletions

File tree

tests/test_vllm_client_server.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
from transformers import AutoModelForCausalLM
2020
from transformers.testing_utils import torch_device
2121

22-
from trl.extras.vllm_client import VLLMClient
22+
from trl.generation.vllm_client import VLLMClient
2323
from trl.import_utils import is_vllm_available
2424
from trl.scripts.vllm_serve import chunk_list
2525

trl/experimental/gold/gold_trainer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -48,7 +48,7 @@
4848

4949
from ...data_utils import is_conversational, maybe_convert_to_chatml, pack_dataset, truncate_dataset
5050
from ...extras.profiling import profiling_decorator
51-
from ...extras.vllm_client import VLLMClient
51+
from ...generation.vllm_client import VLLMClient
5252
from ...import_utils import is_vllm_available
5353
from ...models import prepare_deepspeed
5454
from ...models.utils import unwrap_model_for_generation

trl/experimental/online_dpo/online_dpo_trainer.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -53,7 +53,7 @@
5353

5454
from ...data_utils import apply_chat_template, is_conversational, maybe_apply_chat_template
5555
from ...extras.profiling import profiling_context
56-
from ...extras.vllm_client import VLLMClient
56+
from ...generation.vllm_client import VLLMClient
5757
from ...import_utils import is_vllm_available
5858
from ...models.utils import create_reference_model, prepare_deepspeed, prepare_fsdp, unwrap_model_for_generation
5959
from ...trainer.base_trainer import BaseTrainer
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@
2828
from transformers import is_torch_xpu_available
2929
from urllib3.util.retry import Retry
3030

31-
from ..import_utils import is_requests_available, is_vllm_ascend_available, is_vllm_available
31+
from import_utils import is_requests_available, is_vllm_ascend_available, is_vllm_available
3232

3333

3434
if is_requests_available():
@@ -88,7 +88,7 @@ class VLLMClient:
8888
Use the client to generate completions and update model weights:
8989
9090
```python
91-
>>> from trl.extras.vllm_client import VLLMClient
91+
>>> from trl.generation.vllm_client import VLLMClient
9292
9393
>>> client = VLLMClient()
9494
>>> client.generate(["Hello, AI!", "Tell me a joke"])

trl/generation/vllm_generation.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -29,9 +29,9 @@
2929

3030
from ..data_utils import apply_chat_template, is_conversational, prepare_multimodal_messages_vllm
3131
from ..extras.profiling import ProfilingContext, profiling_decorator
32-
from ..extras.vllm_client import VLLMClient
3332
from ..import_utils import is_vllm_available
3433
from ..trainer.utils import ensure_master_addr_port
34+
from .vllm_client import VLLMClient
3535

3636

3737
if TYPE_CHECKING:

0 commit comments

Comments
 (0)