Remove unimplemented feature selectName (#1205)

Author: seongahjo

docs/content/v1.1.x-kor/docs/customizing-objects/registerByName.md

@@ -117,11 +117,6 @@ inline fun <reified T> FixtureMonkeyBuilder.register(
     noinline arbitraryBuilderGenerator: (fixtureMonkey: FixtureMonkey) -> ArbitraryBuilder<out T>
 ): FixtureMonkeyBuilder = this.register(T::class.java, arbitraryBuilderGenerator)
 
-inline fun <reified T> FixtureMonkeyBuilder.registerByName(
-    registeredName: String,
-    noinline arbitraryBuilderGenerator: (fixtureMonkey: FixtureMonkey) -> ArbitraryBuilder<out T>
-): FixtureMonkeyBuilder = this.registerByName(registeredName, T::class.java, arbitraryBuilderGenerator)
-
 inline fun <reified T> FixtureMonkeyBuilder.registerExactType(
     noinline arbitraryBuilderGenerator: (fixtureMonkey: FixtureMonkey) -> ArbitraryBuilder<out T>
 ): FixtureMonkeyBuilder = this.registerExactType(T::class.java, arbitraryBuilderGenerator)

docs/content/v1.1.x/docs/customizing-objects/registerByName.md

@@ -32,7 +32,6 @@
 import org.apiguardian.api.API;
 import org.apiguardian.api.API.Status;
 
-import com.navercorp.fixturemonkey.annotation.Order;
 import com.navercorp.fixturemonkey.api.constraint.JavaConstraintGenerator;
 import com.navercorp.fixturemonkey.api.container.DecomposedContainerValueFactory;
 import com.navercorp.fixturemonkey.api.generator.ArbitraryContainerInfoGenerator;
@@ -398,11 +397,12 @@ public FixtureMonkeyBuilder registerGroup(Class<?>... arbitraryBuilderGroups) {
 							}
 						};
 
-					if (arbitraryBuilderGroup.isAnnotationPresent(Order.class)) {
-						Order order = arbitraryBuilderGroup.getAnnotation(Order.class);
-						this.register(actualType, registerArbitraryBuilder, order.value());
-						continue;
-					}
+					// TODO: Support Order annotation
+					// if (arbitraryBuilderGroup.isAnnotationPresent(Order.class)) {
+					// 	Order order = arbitraryBuilderGroup.getAnnotation(Order.class);
+					// 	this.register(actualType, registerArbitraryBuilder, order.value());
+					// 	continue;
+					// }
 					this.register(actualType, registerArbitraryBuilder);
 				} catch (Exception ex) {
 					// ignored
@@ -428,34 +428,6 @@ public FixtureMonkeyBuilder registerGroup(ArbitraryBuilderGroup... arbitraryBuil
 		return this;
 	}
 
-	public FixtureMonkeyBuilder registerByName(
-		String registeredName,
-		Class<?> type,
-		Function<FixtureMonkey, ? extends ArbitraryBuilder<?>> arbitraryBuilder
-	) {
-		return this.registerByName(registeredName, type, arbitraryBuilder, DEFAULT_PRIORITY);
-	}
-
-	public FixtureMonkeyBuilder registerByName(
-		String registeredName,
-		Class<?> type,
-		Function<FixtureMonkey, ? extends ArbitraryBuilder<?>> arbitraryBuilder,
-		int priority
-	) {
-		if (registeredPriorityMatchersByName.containsKey(registeredName)) {
-			throw new IllegalArgumentException("Duplicated ArbitraryBuilder name: " + registeredName);
-		}
-		MatcherOperator<Function<FixtureMonkey, ? extends ArbitraryBuilder<?>>> matcherOperator =
-			MatcherOperator.assignableTypeMatchOperator(type, arbitraryBuilder);
-
-		this.registeredPriorityMatchersByName.put(
-			registeredName, new PriorityMatcherOperator<>(
-				matcherOperator.getMatcher(), matcherOperator.getOperator(), priority
-			)
-		);
-		return this;
-	}
-
 	public FixtureMonkeyBuilder plugin(Plugin plugin) {
 		fixtureMonkeyOptionsBuilder.plugin(plugin);
 		return this;

fixture-monkey-kotlin/src/main/kotlin/com/navercorp/fixturemonkey/kotlin/FixtureMonkeyBuilderExtensions.kt

@@ -30,6 +30,6 @@
 @Retention(RetentionPolicy.RUNTIME)
 @Target({ElementType.TYPE})
 @API(since = "1.1.15", status = EXPERIMENTAL)
-public @interface Order {
+@interface Order {
 	int value() default Integer.MAX_VALUE;
 }

fixture-monkey/src/main/java/com/navercorp/fixturemonkey/FixtureMonkeyBuilder.java

@@ -67,7 +67,6 @@
 public final class ArbitraryBuilderContext {
 	private final List<ArbitraryManipulator> manipulators;
 	private final List<ContainerInfoManipulator> containerInfoManipulators;
-	private final List<String> selectNames;
 	private final Map<Class<?>, List<Property>> propertyConfigurers;
 	private final Map<Class<?>, ArbitraryIntrospector> arbitraryIntrospectorsByType;
 	private final MonkeyContext monkeyContext;
@@ -86,7 +85,6 @@ public final class ArbitraryBuilderContext {
 	private ArbitraryBuilderContext(
 		List<ArbitraryManipulator> manipulators,
 		List<ContainerInfoManipulator> containerInfoManipulators,
-		List<String> selectNames,
 		Map<Class<?>, List<Property>> propertyConfigurers,
 		Map<Class<?>, ArbitraryIntrospector> arbitraryIntrospectorsByType,
 		@Nullable FixedState fixedState,
@@ -95,7 +93,6 @@ private ArbitraryBuilderContext(
 	) {
 		this.manipulators = manipulators;
 		this.containerInfoManipulators = containerInfoManipulators;
-		this.selectNames = selectNames;
 		this.propertyConfigurers = propertyConfigurers;
 		this.arbitraryIntrospectorsByType = arbitraryIntrospectorsByType;
 		this.fixedState = fixedState;
@@ -110,7 +107,6 @@ private ArbitraryBuilderContext(
 	@Deprecated
 	public static ArbitraryBuilderContext newBuilderContext(MonkeyContext monkeyContext) {
 		return new ArbitraryBuilderContext(
-			new ArrayList<>(),
 			new ArrayList<>(),
 			new ArrayList<>(),
 			new HashMap<>(),
@@ -128,7 +124,6 @@ public ArbitraryBuilderContext copy() {
 		return new ArbitraryBuilderContext(
 			new ArrayList<>(this.manipulators),
 			copiedContainerInfoManipulators,
-			new ArrayList<>(this.selectNames),
 			new HashMap<>(propertyConfigurers),
 			new HashMap<>(arbitraryIntrospectorsByType),
 			fixedState,
@@ -161,18 +156,6 @@ public List<TreeNodeManipulator> getContainerInfoManipulators() {
 		return Collections.unmodifiableList(containerInfoManipulators);
 	}
 
-	public void addSelectedNames(List<String> selectNames) {
-		for (String selectName : selectNames) {
-			if (!this.selectNames.contains(selectName)) {
-				this.selectNames.add(0, selectName);
-			}
-		}
-	}
-
-	public List<String> getSelectedNames() {
-		return this.selectNames;
-	}
-
 	public void putPropertyConfigurer(Class<?> type, List<Property> propertyConfigurer) {
 		this.propertyConfigurers.put(type, propertyConfigurer);
 	}