INTERNAL: Refactor Operation interface with default methods

Author: Jinyshin

src/main/java/net/spy/memcached/ops/Operation.java

@@ -123,11 +123,17 @@ public interface Operation {
 
   boolean isReadOperation();
 
-  boolean isBulkOperation();
+  default boolean isBulkOperation() {
+    return false;
+  }
 
-  boolean isPipeOperation();
+  default boolean isPipeOperation() {
+    return false;
+  }
 
-  boolean isIdempotentOperation();
+  default boolean isIdempotentOperation() {
+    return true;
+  }
 
   /* ENABLE_MIGRATION if */
   RedirectHandler getAndClearRedirectHandler();

src/main/java/net/spy/memcached/protocol/BaseOperationImpl.java

@@ -28,6 +28,7 @@
 import net.spy.memcached.compat.SpyObject;
 import net.spy.memcached.ops.APIType;
 import net.spy.memcached.ops.CancelledOperationStatus;
+import net.spy.memcached.ops.Operation;
 import net.spy.memcached.ops.OperationCallback;
 import net.spy.memcached.ops.OperationErrorType;
 import net.spy.memcached.ops.OperationException;
@@ -39,7 +40,7 @@
 /**
  * Base class for protocol-specific operation implementations.
  */
-public abstract class BaseOperationImpl extends SpyObject {
+public abstract class BaseOperationImpl extends SpyObject implements Operation {
 
   /**
    * Status object for canceled operations.
@@ -289,8 +290,4 @@ public APIType getAPIType() {
   public void setAPIType(APIType type) {
     this.apiType = type;
   }
-
-  public abstract boolean isBulkOperation();
-
-  public abstract boolean isPipeOperation();
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeFindPositionOperationImpl.java

@@ -129,19 +129,4 @@ public Collection<String> getKeys() {
     return Collections.singleton(key);
   }
 
-  @Override
-  public boolean isBulkOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeFindPositionWithGetOperationImpl.java

@@ -259,19 +259,4 @@ public Collection<String> getKeys() {
     return Collections.singleton(key);
   }
 
-  @Override
-  public boolean isBulkOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeGetBulkOperationImpl.java

@@ -269,14 +269,4 @@ public boolean isBulkOperation() {
     return true;
   }
 
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeGetByPositionOperationImpl.java

@@ -262,19 +262,4 @@ public Collection<String> getKeys() {
     return Collections.singleton(key);
   }
 
-  @Override
-  public boolean isBulkOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeInsertAndGetOperationImpl.java

@@ -293,19 +293,4 @@ public Collection<String> getKeys() {
     return Collections.singleton(key);
   }
 
-  @Override
-  public boolean isBulkOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeSortMergeGetOperationImpl.java

@@ -464,14 +464,4 @@ public boolean isBulkOperation() {
     return true;
   }
 
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BTreeSortMergeGetOperationOldImpl.java

@@ -317,14 +317,4 @@ public boolean isBulkOperation() {
     return true;
   }
 
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }

src/main/java/net/spy/memcached/protocol/ascii/BaseGetOpImpl.java

@@ -237,14 +237,4 @@ public boolean isBulkOperation() {
     return keys.size() > 1;
   }
 
-  @Override
-  public boolean isPipeOperation() {
-    return false;
-  }
-
-  @Override
-  public boolean isIdempotentOperation() {
-    return true;
-  }
-
 }