Merge pull request #19 from CeerDecy/fix/windows-build

fix: conditional checks are performed before the node is actually exe…

Author: CeerDecy

auto-engine-core/src/types/conditions.rs

@@ -38,6 +38,9 @@ impl Conditions {
             && condition != ""
         {
             let condition = utils::parse_variables(ctx, condition).await;
+            if condition == "" {
+                return Ok(false);
+            }
             let result = evalexpr::eval_boolean(&condition)
                 .map_err(|err| format!("{} is not boolean", err))?;
             if !result {

auto-engine-core/src/workflow/runner.rs

@@ -210,18 +210,6 @@ fn handle_nod(
                 )
             };
 
-            if let Some(condition) = node_schema.metadata.conditions {
-                if !condition.check(&ctx).await? {
-                    emitter
-                        .emit(
-                            NODE_EVENT,
-                            NodeEventPayload::skip::<String>(node_id.clone(), None),
-                        )
-                        .unwrap_or_default();
-                    continue;
-                }
-            }
-
             let action = node_schema.action_type.clone();
 
             let (node, mut runner) = {
@@ -268,6 +256,18 @@ fn handle_nod(
                     return Ok(None);
                 }
 
+                if let Some(condition) = node_schema.metadata.conditions {
+                    if !condition.check(&ctx).await? {
+                        emitter
+                            .emit(
+                                NODE_EVENT,
+                                NodeEventPayload::skip::<String>(node_id.clone(), None),
+                            )
+                            .unwrap_or_default();
+                        return Ok(None);
+                    }
+                }
+
                 let mut result: Result<Option<HashMap<String, serde_json::Value>>, String> =
                     Ok(None);
                 if retry <= -1 {