PR Triage Summary — Preparing for Stable 0.30 Release #1009
lnagel
announced in
Announcements
Replies: 1 comment
-
|
@Ilaiwi @developer-ocansey @madisvain Sharing some initial results on the PR triage. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
I reviewed all 23 open pull requests against the current
0.30.0-beta.9codebase. The entire project has been rewritten from JavaScript to TypeScript, moment.js to dayjs, Webpack to Vite, and Enzyme to @testing-library/react. Most older PRs target files that no longer exist. Each PR has been commented on individually with detailed findings.Worth Porting — Bug Fixes (apply directly to current codebase)
These PRs fix real bugs that are confirmed still present. The fixes are small enough to apply directly rather than rebasing the original PRs.
getSumScrollnull checkparentNodeis null during drag (issue #900)Timeline.tsx:526Worth Porting — Features (reimplement against current TS codebase)
These PRs introduce valuable features with sound architecture. They target old JS files so can't merge directly, but the concepts should be carried forward.
shouldStackEnforceOrdergroup param to maintain array order in stacking. Clean, opt-in, backward-compatible approach.rowRendererpropitemRenderer/groupRendererpattern.onEndTimeChangeeventscrolledflag tracking.moveResizeValidatorto return{ dragTime, dragGroupDelta }for constraining both time and group during drag. Backward-compatible.onCollisioncallback after move/resize to detect overlapping items. Concept is good but implementation has bugs (ID vs index mismatch) and should use existingcollision()function.Outdated — Superseded by the 0.30 Rewrite
These PRs target old
.jsfiles that no longer exist and fix issues that have been resolved by the rewrite, or are no longer applicable.Timeline.jsis nowTimeline.tsx, interaction logic rearchitectedTimeline.jsno longer exists, logic rewrittenitemVerticalGapprop already in 0.30Item.jsis nowItem.tsx,moveResizeValidatorsignature changedScrollElement.jsis nowScrollElement.tsx, completely rewritten with Pointer Events APITimeline.jsis nowTimeline.tsx, scroll sync logic restructuredTimeline.jsis nowTimeline.tsx, scroll handler rewrittenstickyHeaderprop removed!defaultvariables for customization,composeEventsrewrittencomponentWillReceivePropsin current sourceDependabot
Key Takeaways
itemVerticalGap(feat: add prop to remove vertical margin between stacked items #889), dayjs migration (Replace moment with datedriver. #819), SCSS customization (Enable Style Customization #659), andcomponentWillReceivePropsremoval (Remove componentWillReceiveProps warning. #651).See also: Issue Triage Summary for the companion review of all 20 open issues.
Beta Was this translation helpful? Give feedback.
All reactions